Support for NuGen Ovation RRBS libraries#379
Open
jma1991 wants to merge 3 commits intonf-core:devfrom
Open
Conversation
Contributor
FelixKrueger
left a comment
There was a problem hiding this comment.
The suggested diversity trimming looks good to me, but do we have specific test data for this?
Author
I have some Ovation test data, shall I submit it to the test-datasets repository? |
Member
|
@jma1991 could you please update / rebase this PR off the latest nf-core |
Contributor
|
@jma1991 checking in here - did you get some test data into the test-datasets repo ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces an initial implementation for processing NuGen Ovation RRBS libraries, drawing guidance from the commands outlined in the NuMetRRBS repository. Currently, the focus is on integrating fundamental steps such as adapter trimming and diversity trimming. Although there's an optional component for deduplicating reads via molecular tags, I'm not sure how to implement this right now. Lastly, let me know if I should submit some Ovation data to the test-datasets repository.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).