This repository was archived by the owner on Aug 9, 2023. It is now read-only.
Open
Conversation
… and abc.Messageable
TAG-Epic
suggested changes
Jan 3, 2022
nextcord/types/embed.py
Outdated
| @@ -0,0 +1,179 @@ | |||
| """ | |||
| The MIT License (MIT) | |||
Contributor
There was a problem hiding this comment.
I honestly dislike the embed api, it looks super messy imo
Author
There was a problem hiding this comment.
I honestly dislike the embed api, it looks super messy imo
Oh? Why that? Because of a class per Proxy?
Or maybe I should add some set_* functions to the Embed class?
TAG-Epic
suggested changes
Jan 8, 2022
Member
|
for your class methods, doesnt |
Author
Yeah in that case it does, so imma change it but the embed API will need changes anyways, still unsure how/what to change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some models, updates .gitignore so my editor's config isn't pushed, and linted everything (some commits from master weren't linted, so I did)