fix(preview): handle null mime type in preview generation#58802
Open
boris324 wants to merge 1 commit intonextcloud:masterfrom
Open
fix(preview): handle null mime type in preview generation#58802boris324 wants to merge 1 commit intonextcloud:masterfrom
boris324 wants to merge 1 commit intonextcloud:masterfrom
Conversation
boris324
requested review from
ArtificialOwl,
artonge,
nfebe and
sorbaugh
and removed request for
a team
Member
|
Another approach here: #58793 Cc @CarlSchwan since you reviewed ;) PS: why set a default mimetype to png if it fails? Seems arbitrary, but maybe I just don't get it 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58784
IImage::dataMimeType()can returnnullfor edge-case images (e.g. a GIF with dimensions 18x4312), butPreview::setMimeType()expects a non-null string. This causes a TypeError during preview generation.This patch adds a null coalesce fallback to
image/png(the default preview format) at both call sites inGenerator.phpwheredataMimeType()is passed tosetMimeType(). This prevents the crash and allows preview generation to complete gracefully.Added a test case covering preview generation when the image has a null MIME type.