fix: increase bucket_name column length to 63 chars#58758
Open
boris324 wants to merge 1 commit intonextcloud:masterfrom
Open
fix: increase bucket_name column length to 63 chars#58758boris324 wants to merge 1 commit intonextcloud:masterfrom
boris324 wants to merge 1 commit intonextcloud:masterfrom
Conversation
boris324
requested review from
ArtificialOwl,
come-nc,
leftybournes,
sorbaugh and
szaimen
and removed request for
a team
come-nc
reviewed
Mar 9, 2026
| </NcFormBox> | ||
| <NcRadioGroup | ||
| v-model="store.userConfig.default_view" | ||
| name="default_view" |
Contributor
There was a problem hiding this comment.
Suggested change
| name="default_view" |
I guess this is a mistake?
Author
There was a problem hiding this comment.
Yeah, that was from another branch that got mixed in by mistake. Removed it now, force pushed with only the bucket_name migration commit.
AWS allows bucket names up to 63 characters per their naming rules, but the bucket_name column in oc_preview_locations was varchar(40). This updates the initial migration to use length 63 for fresh installs and adds a new migration to alter the column for existing installs. Fixes: nextcloud#58755 Signed-off-by: boris324 <boris324@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
boris324
force-pushed
the
fix/bucket-name-length
branch
from
8ea6b7e to
9c14810
Compare
Author
|
Let me fix it
Thank you for your help.
…On Mon, Mar 9, 2026 at 7:50 PM Côme Chilliet ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In apps/files/src/components/FilesAppSettings/FilesAppSettingsGeneral.vue
<#58758 (comment)>:
> @@ -37,6 +37,7 @@ const store = useUserConfigStore()
</NcFormBox>
<NcRadioGroup
v-model="store.userConfig.default_view"
+ name="default_view"
⬇️ Suggested change
- name="default_view"
I guess this is a mistake?
—
Reply to this email directly, view it on GitHub
<#58758 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANL5E4B5L4FHMQ7KQ75DRU34P2OV5AVCNFSM6AAAAACWJYUYDWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTSMJUGUZDQMZVGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bucket_namecolumn length inoc_preview_locationsfromvarchar(40)tovarchar(63)Changes
core/Migrations/Version33000Date20250819110529.php- Updated initial schema to definebucket_namewith length 63 instead of 40core/Migrations/Version33000Date20260306120000.php- New migration that increases thebucket_namecolumn length to 63 for existing installationsFixes #58755
Test plan
oc_preview_locations.bucket_namecolumn is created asvarchar(63)varchar(40): verify the new migration alters the column tovarchar(63)🤖 Generated with Claude Code