Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
solracsf
force-pushed
the
improveDbPerformance
branch
from
7f608c4 to
5c6c880
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Git'Fellow <[email protected]>
solracsf
force-pushed
the
improveDbPerformance
branch
from
5c6c880 to
0202a72
Compare
solracsf
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
solracsf
requested review from
elzody,
grnd-alt and
luka-nextcloud
as code owners
grnd-alt
approved these changes
Mar 31, 2026
Member
grnd-alt
left a comment
grnd-alt
left a comment
There was a problem hiding this comment.
great work, thanks 🔥
I don't know if the test really tests anything tbh as it just checks if the new functions are used and not how many db queries are done...
also some comments in there that just describe what the function name already says basically.
But all in all I'm fine to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Loading a board with many cards triggered thousands of individual DB queries, one per card for attachment counts, stack lookups, and label/user assignments.
This introduces batch query methods across the mapper and service layers so that all data for a set of cards is fetched in a single query regardless of board size, and adds a performance test suite asserting the batching holds for a 13 boards × 100 cards × 5 attachments scenario.
Checklist