Skip to content

Update Cisco ASA show interface detail and show version#2248

Draft
alishahbazi360 wants to merge 2 commits intonetworktocode:masterfrom
alishahbazi360:master
Draft

Update Cisco ASA show interface detail and show version#2248
alishahbazi360 wants to merge 2 commits intonetworktocode:masterfrom
alishahbazi360:master

Conversation

@alishahbazi360
Copy link

No description provided.

@mjbear
Copy link
Collaborator

mjbear commented Nov 28, 2025

Hi @alishahbazi360
Please submit only one template per pull request.

Any template addition or change needs to be accompanied with test data including raw cli output for the situation being solved.

The development helper scripts can assist in creating the parsed yml from the raw output.

@mjbear mjbear added the changes_requested Waiting on user to address feedback label Nov 28, 2025
@mjbear mjbear changed the title Updating Cisco ASA parsing for "show interface detail" and "show version" Update Cisco ASA show interface detail and show version Dec 13, 2025
@mjbear
Copy link
Collaborator

mjbear commented Dec 13, 2025

Hi @alishahbazi360 Please submit only one template per pull request.

Any template addition or change needs to be accompanied with test data including raw cli output for the situation being solved.

The development helper scripts can assist in creating the parsed yml from the raw output.

@alishahbazi360
Please respond.

  • Related test data needs to accompany the template changes.

  • Please split the ASA show version changes into its own feature branch.

@mjbear mjbear added the status: action required This issue requires additional information to be actionable label Feb 1, 2026
@mjbear
Copy link
Collaborator

mjbear commented Feb 8, 2026

Hi @alishahbazi360 Please submit only one template per pull request.
Any template addition or change needs to be accompanied with test data including raw cli output for the situation being solved.
The development helper scripts can assist in creating the parsed yml from the raw output.

@alishahbazi360 Please respond.

* Related test data needs to accompany the template changes.

* Please split the ASA `show version` changes into its own [feature branch](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-branches).

Hi @alishahbazi360

  • Please add test data
  • Please create two branches - one per template
  • We should not be removing the Error directive so this needs further discussion

@mjbear mjbear marked this pull request as draft February 8, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes_requested Waiting on user to address feedback status: action required This issue requires additional information to be actionable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants