feat: allow multiple module paths in router module#16053
Open
kr-78493 wants to merge 1 commit intonestjs:masterfrom
Open
feat: allow multiple module paths in router module#16053kr-78493 wants to merge 1 commit intonestjs:masterfrom
kr-78493 wants to merge 1 commit intonestjs:masterfrom
Conversation
The Router module allows defining multiple paths for a module. This enhancement updates the route resolution logic to accommodate multiple paths, ensuring that all specified paths are correctly registered and logged. Closes nestjs#16052
Pull Request Test Coverage Report for Build 52e28be4-62ac-4c8b-b842-b656b80f3c58Details
💛 - Coveralls |
1 task
Author
|
@kamilmysliwiec Do you think that feature makes sense and has a chance of getting merged. If yes, I will add some additional tests and you can propose some changes if you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Router module allows defining multiple paths for a module. This enhancement updates the route resolution logic to accommodate multiple paths, ensuring that all specified paths are correctly registered and logged.
Controllers allow the definition of multiple basePaths like this:
@controller(['equipment/:assetId', 'assets/:assetId'])
I want to bring the same functionality to the RouteModule such that we can nest controllers like this:
RouterModule.register([ { path: ['equipment/:assetId', 'assets/:assetId'], module: AssetModule, } ]),
Closes #16052
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information