fix(sample): update gql federation samples to use production-ready#15539
Open
mag123c wants to merge 1 commit intonestjs:masterfrom
Open
fix(sample): update gql federation samples to use production-ready#15539mag123c wants to merge 1 commit intonestjs:masterfrom
mag123c wants to merge 1 commit intonestjs:masterfrom
Conversation
15 tasks
Contributor
Author
|
coverage collected failed 😨😨 |
|
Two questions here: Is the usage of rover CLI mandatory for generating super graph or is it just an alternative to the first generation method? This is not 100% from the text IMO What would happen if one of the backend applications does not startup? Will the gateway keep crashing or will it simply return 500 for those methods requiring those services? Is the behavior the same even after startup? |
Contributor
Author
Q1.No, Rover CLI is NOT mandatory. The implementation provides two methods:
As shown in the code // generate-supergraph.ts:108-114
const useRover = process.argv.includes('--rover');
if (useRover) {
generateSupergraph(); // Uses Rover
} else {
generateSupergraphLocal(); // Local generation (no Rover needed)
}The README clearly states these are alternatives, with Rover being the production-recommended approach but not mandatory. Q2.Current implementation (static supergraphSdl)
IntrospectAndCompose behavior (commented out)
|
Hardanish-Singh
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The GraphQL Federation sample applications (both code-first and schema-first) use IntrospectAndCompose from @apollo/gateway, which is not production-ready. This approach:
Issue Number: #14676
What is the new behavior?
The updated samples now demonstrate production-ready patterns:
- generate:supergraph: Local development using file-based composition
- generate:supergraph:rover: Production using Apollo Rover CLI
The samples now provide a clear migration path from development to production, following Apollo Federation best practices.
Does this PR introduce a breaking change?