Open
Conversation
…when visiting terminal
🦋 Changeset detectedLatest commit: 289abc7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previosly we would error when ANTLR did error recovery for nodes in the middle of a query. We could already handle cases like
MATCH (n) WHERX (n:Person) RETURN nwhere the parsing fails completely in the middle. The formatter then only formats up until the "unparseable" part and inserts the rest of the query as-is.Sometimes though, like in
MATCH (n:-) RETURN nantlr recovers, inserting an error-node on the-but correctly parsing the "RETURN n" part afterward. Before this fix we would throw an error in this case, because we didnt visit the error node, causing it to not be inserted to any of the formatted chunks - thus effectively being deleted. The fix we have here is to insert missed preceding error nodes (with the content as-is) when creating a chunk in thevisitTerminalandvisitTerminalRawfor properly parsed rules.Claude got a bit lost while testing things, so I interrupted it and made the final steps myself, but it's an agent-driven PR.
Closes LS-138
Fixes LS-138