feat: implement JSON rpc client and extractor for bitcoin#1980
feat: implement JSON rpc client and extractor for bitcoin#1980
Conversation
gilcu3
left a comment
There was a problem hiding this comment.
I have two (small) blockers related to the network requests:
- We are supporting only POST, but RPCs might also use GET I assume
- In the headers we only allow a single header. To have full generality, we should accept any number of them
netrome
left a comment
There was a problem hiding this comment.
Good stuff. Some thoughts from my end. My main concern is if it's too limiting to restrict us to one RPC call per inspector. Secondly I think we should use associated types instead of generics in the traits, that would be cleaner. But none of these are blocking, and both can be tackled separately or not at all.
This first revision is only supporting the bitcoin core API which uses JSON-RPC. Json-rpc requests sent over HTTP are always
This ask of multiple header is relevant to you, @netrome , since your PR is creating the config spec for authentication. I see your design also went with supporting only one header I currently don't see why we would need more than one header for authentication, but it's a simple change. @gilcu3 Do you have a specific use case in mind for setting multiple authentication headers? |
netrome
left a comment
There was a problem hiding this comment.
Thanks for updating to use associated types 🙏
closes #1941