Skip to content

Test for out of order data plotting#8285

Merged
akhenry merged 3 commits intomasterfrom
plots-out-of-order-tests
Mar 26, 2026
Merged

Test for out of order data plotting#8285
akhenry merged 3 commits intomasterfrom
plots-out-of-order-tests

Conversation

@shefalijoshi
Copy link
Copy Markdown
Contributor

@shefalijoshi shefalijoshi commented Mar 23, 2026

Closes #8283

Describe your changes:

Add test to ensure out of order data plotting doesn't draw backwards interpolation lines

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@shefalijoshi shefalijoshi added the type:maintenance tests, chores, or project maintenance label Mar 23, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.55%. Comparing base (e7e53fe) to head (5efbd62).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8285      +/-   ##
==========================================
+ Coverage   56.26%   57.55%   +1.29%     
==========================================
  Files         725      725              
  Lines       29328    29328              
  Branches     2795     2795              
==========================================
+ Hits        16500    16879     +379     
+ Misses      12488    12109     -379     
  Partials      340      340              
Flag Coverage Δ
e2e-ci 65.07% <100.00%> (+4.59%) ⬆️
e2e-full 40.20% <0.00%> (-0.05%) ⬇️
unit 46.81% <0.00%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
example/generator/StateGeneratorProvider.js 100.00% <100.00%> (+7.14%) ⬆️
src/api/forms/components/controls/NumberField.vue 0.00% <ø> (ø)
...pi/forms/components/controls/ToggleSwitchField.vue 0.00% <ø> (ø)
src/ui/components/ToggleSwitch.vue 0.00% <ø> (ø)

... and 38 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7e53fe...5efbd62. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@akhenry akhenry self-requested a review March 26, 2026 22:11
Copy link
Copy Markdown
Contributor

@akhenry akhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Very impressive method of determining if the gl buffer is out of order!

@akhenry akhenry merged commit bfbd001 into master Mar 26, 2026
20 of 22 checks passed
@akhenry akhenry deleted the plots-out-of-order-tests branch March 26, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:maintenance tests, chores, or project maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automated test for out of order plots rendering

2 participants