fix: Add tolerance buffer for gauge real-time updates with clock drift#8220
Open
harshaljanjani wants to merge 1 commit intonasa:masterfrom
Open
fix: Add tolerance buffer for gauge real-time updates with clock drift#8220harshaljanjani wants to merge 1 commit intonasa:masterfrom
harshaljanjani wants to merge 1 commit intonasa:masterfrom
Conversation
Author
Author
|
Good day, any updates on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First contribution!
Closes #8019
Describe your changes:
→ Fixes gauge component not updating consistently in real-time mode when time bounds end is set to "now". The gauge was rejecting telemetry data with timestamps slightly in the future due to clock drift / network latency / server time differences. This fix adds a 1-second tolerance buffer to the end-of-bounds check, allowing near-future data to be accepted while still filtering out genuinely out-of-bounds telemetry.
Steps to Reproduce the Bug (Before Fix)
→ Open the tutorial in browser (https://github.com/nasa/openmct-tutorial)
→ Click "Create" → "Gauge"
→ Save the gauge in "My Items"
→ Click "Create" → "Overlay Plot"
→ Save the plot in "My Items"
→ Expand "Example Spacecraft" in the left tree
→ Drag "Generator Temperature" onto the Gauge object in the tree
→ Drag "Generator Temperature" onto the Plot object in the tree
→ Navigate to the Gauge view
Observed (Buggy) Behavior:
❌ Gauge updates sporadically (every 20-25 seconds)
❌ Plot updates smoothly and continuously
❌ Gauge and plot have inconsistent update frequencies despite receiving the same telemetry stream
Steps to Verify the Fix (After Fix)
→ Follow the same reproduction steps above
→ Navigate between Gauge and Plot views
Expected (Fixed) Behavior:
✅ Gauge updates smoothly and continuously (multiple times per second)
✅ Plot updates smoothly and continuously
✅ Both gauge and plot have consistent update frequencies
✅ Gauge shows current real-time values without delay
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist