[Folders] Add LAD Table and Stacked Plot views#8213
Open
heathdutton wants to merge 1 commit intonasa:masterfrom
Open
[Folders] Add LAD Table and Stacked Plot views#8213heathdutton wants to merge 1 commit intonasa:masterfrom
heathdutton wants to merge 1 commit intonasa:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds default telemetry visualization capabilities to folders by introducing LAD Table and Stacked Plot view providers. The implementation enables users to view telemetry items within a folder's composition using these visualization types, with defensive filtering to handle non-telemetry items gracefully.
Key changes:
- Adds two new view providers for folders:
FolderLadTableViewProviderandFolderStackedPlotViewProvider - Implements defensive filtering in
LadTable.vueandStackedPlot.vueto skip non-telemetry objects
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/plugins/folderView/FolderLadTableViewProvider.js |
New class-based view provider enabling LAD Table view for folder types |
src/plugins/folderView/FolderStackedPlotViewProvider.js |
New function-based view provider enabling Stacked Plot view for folder types |
src/plugins/folderView/plugin.js |
Registers the two new view providers with the OpenMCT instance |
src/plugins/LADTable/components/LadTable.vue |
Adds telemetry check in addItem method to filter out non-telemetry objects |
src/plugins/plot/stackedPlot/StackedPlot.vue |
Adds telemetry and overlay plot type check in addChild method to filter out non-plottable objects |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ef57b0c to
c912c3a
Compare
Add default telemetry views for folders containing telemetry objects. When viewing a folder, users can now select LAD Table or Stacked Plot views to visualize telemetry items within the folder's composition. Simple test included.
1e4e3ac to
f4b9e7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8105
Describe your changes:
Adds default telemetry views for folders, allowing users to visualize telemetry items within a folder's composition as a LAD Table or Stacked Plot.
FolderLadTableViewProvider- enables LAD Table view for foldersFolderStackedPlotViewProvider- enables Stacked Plot view for foldersLadTable.vueandStackedPlot.vueto gracefully skip non-telemetry items in compositionTesting:
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist