Derived Telemetry Prototype #7815

scottbell · 2024-08-20T16:32:06Z

Describe your changes:

Closes #7823

Add a new object called "Derived Telemetry" that allows telemetry to be used in simple mathematical expressions.

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

Changes address original issue?
Tests included and/or updated with changes?
Has this been smoke tested?
Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
Have you associated a milestone with this PR? Note: leave blank if unsure.
Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

Changes appear to address issue?
Reviewer has tested changes by following the provided instructions?
Changes appear not to be breaking changes?
Appropriate automated tests included?
Code style and in-line documentation are appropriate?

- Markup/CSS sanding and shimming for derived telemetry front-end. - Toggle switch CSS improved to use `gap` instead of left margin.

…ry-comps

…ug for truthy/falsy

shefalijoshi · 2025-07-22T19:32:50Z

If the parameter type doesn't match the expression operation, there is no error shown to the user. The operation fails silently.
For example, trying to add the Name with the Sine value here throws an error in the console, but nothing is displayed to the user.

shefalijoshi · 2025-07-22T16:42:10Z

src/api/telemetry/TelemetryCollection.js

    this._setTimeSystem(this.options.timeContext.getTimeSystem());
    this.lastBounds = this.options.timeContext.getBounds();
+    // prioritize passed options over time bounds
+    if (this.options.start) {


Since we're standardizing request options in this._requestHistoricalTelemetry();, recommend moving the assignment of this.lastBounds into that function after options are standardized.

@jvigliotta Need your thoughts here.

added a couple comments!

shefalijoshi · 2025-07-22T18:13:02Z

src/plugins/plot/configuration/PlotSeries.js

+      // if derived, we can't use the old data
+      let data = this.getSeriesData();
+
+      if (this.metadata.value(this.get('yKey')).derived) {


I don't understand this. Why can't we show historic computed/derived telemetry?

shefalijoshi · 2025-07-22T18:18:10Z

src/plugins/plot/stackedPlot/StackedPlotItem.vue

              ],
-              yAxis: persistedSeriesConfig.yAxis
+              yAxis: persistedSeriesConfig.yAxis,
+              ...this.childObject.configuration


This shows 2 Config tabs in the inspector - One for the derived telemetry item and one for the stacked plot Config.

shefalijoshi · 2025-07-22T18:25:25Z

src/plugins/comps/components/CompsView.vue

+                :aria-label="`Reference ${parameter.name} Object Path`"
+              >
+                <ObjectPathString
+                  :domain-object="compsManager.getTelemetryObjectForParameter(parameter.keyString)"


skeptical of calling the compsManager.getTelemetryObjectForParameter method here.

shefalijoshi · 2025-07-22T18:49:33Z

src/plugins/comps/components/CompsView.vue

+  // Because this is triggered by a composition change, we have
+  // to defer mutation of our domain object, otherwise we might
+  // mutate an outdated version of the domain object.
+  setTimeout(function () {


Consider observing the composition property of the domainObject instead of the parameterAdded, parameterRemoved events to make this change.
We should not need this setTimeout.

jvigliotta

Couple thoughts added inline

jvigliotta · 2025-07-23T18:54:09Z

src/api/telemetry/TelemetryCollection.js

   */
  async _requestHistoricalTelemetry() {
    const options = this.openmct.telemetry.standardizeRequestOptions({ ...this.options });
+    this.lastBounds = {


I think this is ok from what I can see. You've added or removed other items that seem to cover this change. We'll definitely need to thoroughly test time conductor/fixed/realtime functionality though.

jvigliotta · 2025-07-23T18:54:53Z

src/api/telemetry/TelemetryCollection.js

   * @private
   */
-  _processNewTelemetry(telemetryData) {
+  _processNewTelemetry(telemetryData, isSubscriptionData = false) {


I think with the below commented out code, isSubscriptionData isn't used really anymore?

jvigliotta · 2025-07-23T18:57:46Z

src/api/telemetry/TelemetryCollection.js


    this.loaded = true;
+
+    return historicalTelemetryLoadedPromise;


I think we'll need to update the docs for this method to show it's returning a promise now for the historical request?

jvigliotta · 2025-07-23T19:04:16Z

src/plugins/comps/CompsManager.js

+        this.#telemetryLoadedPromises.push(telemetryLoadedPromise);
+      }
+    });
+    await Promise.all(this.#telemetryLoadedPromises);


We may be able to use something like we do in tables here:

openmct/src/plugins/telemetryTable/TelemetryTable.js

Lines 181 to 182 in f4637b8

this.telemetryCollections[keyString].on('requestStarted', this.incrementOutstandingRequests);

this.telemetryCollections[keyString].on('requestEnded', this.decrementOutstandingRequests);

then we don't need to change the load() method of telemetry collections?

That's a good idea. I'll try that.

jvigliotta · 2025-07-23T19:05:22Z

src/api/telemetry/TelemetryCollection.js

    this._setTimeSystem(this.options.timeContext.getTimeSystem());
    this.lastBounds = this.options.timeContext.getBounds();
+    // prioritize passed options over time bounds
+    if (this.options.start) {


added a couple comments!

…ry-comps

shefalijoshi · 2026-02-01T15:48:42Z

src/plugins/comps/components/CompsView.vue

+
+function reload() {
+  clearData();
+  outputTelemetryCollection._requestHistoricalTelemetry();


Huh. Interesting...Need to check this. We shouldn't be calling internal methods.

scottbell added 30 commits July 25, 2024 11:55

skeleton for comps

4316003

more scaffolding

6c74e84

more drafts

f5d7a33

add comps manager

0dd0442

worker ready

ff81454

telemetry is null for some reason

74c3a95

can add two sin waves

ce5e435

adding works

69db534

exact values enabled

90a24b3

subscriptions work

37d222f

Merge remote-tracking branch 'origin/master' into telemetry-comps

55c8609

slowing adding gui

a94c752

fix plots

0113ec0

rudimentary expression editor

a0a2ead

correctly persist

e5719fc

parameters

0326e38

can take arbitrary expressions

413338d

styles and timing for loading worker

f174515

ui works kinda

9e3e739

need to figure out ranger

dcc8938

works with time

87dc272

timesystem works

df3ca84

get rid of batch for now

484a81b

gui still leaking data

446c811

memory conserved

aa8750e

styles

4d546fb

Merge remote-tracking branch 'origin/master' into telemetry-comps

d6c8bee

fix initial load

d7d7913

expression validator

d4b2986

fix test data

a9d63b9

charlesh88 and others added 2 commits November 15, 2024 12:29

Closes #7823

64ae96e

- Markup/CSS sanding and shimming for derived telemetry front-end. - Toggle switch CSS improved to use `gap` instead of left margin.

Merge remote-tracking branch 'origin/master' into telemetry-comps

5683320

scottbell mentioned this pull request Nov 15, 2024

Derived Telemetry Prototype #7823

Open

Merge branch 'master' into telemetry-comps

5e15af1

akhenry removed this from the Target:4.1.0 milestone Jan 29, 2025

Merge branch 'master' into telemetry-comps

6770390

shefalijoshi requested review from shefalijoshi and removed request for ozyx and unlikelyzero July 7, 2025 22:29

shefalijoshi added 4 commits July 10, 2025 12:31

Merge branch 'master' of https://github.com/nasa/openmct into telemet…

8474b35

…ry-comps

Update package lock for new package versions

7881093

Move composition policy to it's own file. Fix expression evaluation b…

68aec64

…ug for truthy/falsy

fix lint spelling

1f76741

shefalijoshi added this to the Dependency updates milestone Jul 21, 2025

shefalijoshi added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 21, 2025

shefalijoshi added 2 commits July 22, 2025 16:04

Use the telemetry collection's timeKey for timestamps

0791f4a

Revisit code to use bounds provided by options to telemetryCollections

66f2d7d

shefalijoshi reviewed Jul 23, 2025

View reviewed changes

jvigliotta requested changes Jul 23, 2025

View reviewed changes

shefalijoshi added 2 commits September 16, 2025 14:13

Merge branch 'master' of https://github.com/nasa/openmct into telemet…

4d01d0d

…ry-comps

Merge branch 'master' of https://github.com/nasa/openmct into telemet…

a7c5768

…ry-comps

akhenry added the rodap label Nov 17, 2025

akhenry requested review from akhenry and jvigliotta and removed request for akhenry and charlesh88 November 17, 2025 19:43

github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 17, 2025

Merge branch 'master' of https://github.com/nasa/openmct into telemet…

454287d

…ry-comps

shefalijoshi reviewed Feb 1, 2026

View reviewed changes

	this.telemetryCollections[keyString].on('requestStarted', this.incrementOutstandingRequests);
	this.telemetryCollections[keyString].on('requestEnded', this.decrementOutstandingRequests);

Derived Telemetry Prototype #7815

Are you sure you want to change the base?

Derived Telemetry Prototype #7815

Conversation

scottbell commented Aug 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes:

All Submissions:

Author Checklist

Reviewer Checklist

Uh oh!

shefalijoshi commented Jul 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jvigliotta left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

scottbell commented Aug 20, 2024 •

edited

Loading