Skip to content

CCSDS AOS Deframer #4779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Willmac16 wants to merge 100 commits into
base: devel
Choose a base branch
from
Open

CCSDS AOS Deframer #4779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
100 commits
Select commit Hold shift + click to select a range
5ff3623
Init AOS (De)Framer from TC & TM
Willmac16 Nov 29, 2025
cb9e6a4
Add AOS Suppport Subset list to sdd
Willmac16 Nov 29, 2025
7ceb8f4
Start Refining AOS Framer User Interface
Willmac16 Nov 29, 2025
7f4fb67
Move PVN to Types.fpp & Fill out TFVN
Willmac16 Nov 30, 2025
8a93680
AOS Framer Header
Willmac16 Nov 30, 2025
1acb389
Refactor the Virtual Channel as a struct
Willmac16 Dec 7, 2025
7cadcfa
More work on idle packet serialization
Willmac16 Dec 30, 2025
48f4f93
Move PVN back into ComCfg
Willmac16 Jan 9, 2026
a3ebe4e
AosFramer Builds
Willmac16 Jan 9, 2026
ec86e58
More Section Number & Refactor Sending, Packing, & Header Writing logic
Willmac16 Jan 9, 2026
d91a80e
Start Cleaning up AosFramer w/ Unit Tests
Willmac16 Jan 10, 2026
060384e
Ensure SPP Idle Fill increments payload offset
Willmac16 Jan 12, 2026
1aea426
Mask & shift (don't shift masks)
Willmac16 Jan 12, 2026
43a4d5d
Nothing too large & sendNow for buffer ownership test
Willmac16 Jan 12, 2026
925acd1
Fix SeqCount wrap around test
Willmac16 Jan 12, 2026
3c41505
Created, but failing long packet test
Willmac16 Jan 13, 2026
88fba1c
Add 2 TODOs
Willmac16 Jan 13, 2026
3510bd1
Make AosFrmer Happy on aarch64
Willmac16 Jan 17, 2026
3a0bf8d
Add lldb vscode launch.json config
Willmac16 Jan 17, 2026
7421a9f
Passing striped packet test (Packet across multiple frames)
Willmac16 Jan 17, 2026
7c6ecee
Correct Author & Prune Outdated content from sdd
Willmac16 Jan 17, 2026
b11d95f
Add SPP Idle header asserts
Willmac16 Jan 17, 2026
aa6be5d
Test many packets per frame (short packets)
Willmac16 Jan 17, 2026
98177db
Remove (the not yet implemented) AosDeframer
Willmac16 Jan 17, 2026
2a211c3
Add more words to expected
Willmac16 Jan 17, 2026
3d6e1da
More spelling
Willmac16 Jan 17, 2026
33725a6
Docs spelling
Willmac16 Jan 17, 2026
7da39da
Apply a subset of the spelling bot patch
Willmac16 Jan 17, 2026
255a041
fix `re-entrancy` and fight w/ `aos` spelling pattern
Willmac16 Jan 17, 2026
6f5fcf0
just `aos`
Willmac16 Jan 17, 2026
e615192
`aos` -> `Aos`
Willmac16 Jan 17, 2026
20e3019
Revert launch.json and macos library duplicate change in other PR
Willmac16 Jan 23, 2026
40ccc25
Correct annotations for PVN dict
Willmac16 Jan 23, 2026
ee37e6d
Make Spacing uniform for ComCfg.fpp annotations
Willmac16 Jan 23, 2026
f46b0dd
Rename compute_fecf to compute_and_inject_fecf
Willmac16 Jan 23, 2026
04b6fd6
Correct sdd's description of provided service to VCP
Willmac16 Jan 23, 2026
98a89e2
Add a pair of asserts to try to make RHEL compile CICD happy
Willmac16 Jan 23, 2026
cd9eb5b
Add pack_pad_send helper to avoid pack_packet reentrancy
Willmac16 Jan 23, 2026
39b5755
Update sdd to point at version 5 of the AOS SDL Standard
Willmac16 Jan 30, 2026
da57e04
Default FECF on & constant driven AOS Frame Size
Willmac16 Jan 30, 2026
8734acc
More RHEL8 appeasal
Willmac16 Jan 30, 2026
2f47c9a
RHEL8 UT Appeasement
Willmac16 Feb 1, 2026
bab9756
VC ID default to 1, replay flag gone, & serialize idle spp takes a U16
Willmac16 Feb 3, 2026
71a2aa3
Improve comment about 24 + 4 bit frame count
Willmac16 Feb 3, 2026
cbab740
More RHEL8 UT complaints
Willmac16 Feb 3, 2026
40b108a
expect.txt `bitfield`
Willmac16 Feb 3, 2026
fe4254c
Back to expecting `Bitfield`
Willmac16 Feb 3, 2026
2492f42
Shift then Mask to hopefully silence RHEL UT
Willmac16 Feb 3, 2026
b6da646
spelling
Willmac16 Feb 3, 2026
59c7bb3
Try Unsigned masks
Willmac16 Feb 3, 2026
bd39f50
Add back in Darwin linker dupe warning suppression
Willmac16 Feb 4, 2026
25c02a8
Promote to unsigned int before masking or shifting
Willmac16 Feb 4, 2026
739ebf0
Hope that U32 cast is enough to ward of promotion
Willmac16 Feb 5, 2026
ac82a34
Try separate bitwise or and equals for RHEL 8 issues
Willmac16 Feb 13, 2026
d1f070f
Add AOS Deframer component with EPP support
claude Feb 1, 2026
d331bc7
Make it Compile
Willmac16 Feb 14, 2026
301a7cd
Address PR review comments and fix spell check failures
github-actions[bot] Feb 19, 2026
1afbb41
Merge branch 'devel' into aos-framing
Willmac16 Feb 23, 2026
672b76a
Remove Pvn from ComCfg
Willmac16 Feb 23, 2026
c585a12
EPP is 7 not 3
Willmac16 Feb 24, 2026
9ace3ac
Merge branch 'aos-framing' into aos-deframer
Willmac16 Feb 24, 2026
59c700b
Address review feedback: refactor events/telem, fix PvnBitfield, remo…
github-actions[bot] Feb 24, 2026
4806151
Just enough to compile
Willmac16 Feb 25, 2026
fa86856
More AosDeframer UTs
Willmac16 Feb 25, 2026
4c61464
Move Test Helpers to separate file
Willmac16 Feb 25, 2026
9bb70bb
Clean up Types.fpp
Willmac16 Feb 25, 2026
b77265b
NumVcs const
Willmac16 Feb 25, 2026
ea3eaa1
Normalize Transmitted/Actual vs Expected/Configured ordering of mismatch
Willmac16 Feb 25, 2026
e69fc7c
Improve clarity on different vc struct counts
Willmac16 Feb 25, 2026
ca470c3
Algin telem & member var for 3 types of counts
Willmac16 Feb 25, 2026
8e0beb6
FECF first & vc as pointer (allow null return)
Willmac16 Feb 25, 2026
073b4ea
notifyErrorIfConnected helper
Willmac16 Feb 25, 2026
6c77929
WIP: Gap Detect
Willmac16 Feb 25, 2026
bb96861
Reset Spanning
Willmac16 Feb 25, 2026
c257f5a
Steal back the Dyn backed spanning packet logic from 567ec7b
Willmac16 Feb 25, 2026
2381194
Couple more tweaks from an alt timeline
Willmac16 Feb 25, 2026
cd796e8
Minor Cleanup
Willmac16 Feb 26, 2026
76a4fe9
So Much TODO
Willmac16 Feb 26, 2026
6f82f8c
Valid but disabled packet warning
Willmac16 Feb 26, 2026
1603200
Use ApidMask in AosDeframer
Willmac16 Feb 26, 2026
8713742
Make the tests happy
Willmac16 Feb 26, 2026
c441301
appendToSpanningPacket is now a void return
Willmac16 Feb 26, 2026
3a7dea7
Fix EPP & appendToSpanning I'm happy w/
Willmac16 Feb 27, 2026
71b0987
Actually Builds
Willmac16 Feb 27, 2026
4ddbec4
Low Effort TODOs
Willmac16 Feb 27, 2026
1bfd65b
Use the SpacePacketHeader w/ deserialize for sizeSppPacket
Willmac16 Feb 27, 2026
fc7c373
Tests fail, but are small & compile
Willmac16 Feb 27, 2026
1f0cbdc
on alloc failure should move to next packet
Willmac16 Feb 27, 2026
e919572
About to clean slate the tests
Willmac16 Feb 27, 2026
7506006
Remember how to nominal frame
Willmac16 Feb 27, 2026
fe7c11c
Mostly Passing
Willmac16 Feb 27, 2026
233a510
All passing
Willmac16 Feb 27, 2026
bc3b108
Remove unused invalid EPP & SPP events
Willmac16 Feb 27, 2026
9a99ef3
Fix epp length writing (hopefully) and add some more coverage
Willmac16 Feb 27, 2026
a62b783
Reduce duplicate length checking, EPP Length of Length is not a number,
Willmac16 Feb 27, 2026
52ec663
Assert we have at least one byte
Willmac16 Feb 27, 2026
4020941
Packet Abandonment event + test, frame count tlm checks, & fix for
Willmac16 Feb 27, 2026
43fa832
Spelling + assert on the vcID
Willmac16 Feb 27, 2026
f61e57e
Add `lol` to expect.txt
Willmac16 Feb 27, 2026
5e1d921
Merge branch 'devel' into aos-deframer
Willmac16 Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/actions/spelling/expect.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
ampcs
ANamespace
Aos
aosmpdu
apid
APIDOCS
APPENDFILE
Expand Down Expand Up @@ -42,7 +43,7 @@
binaryfile
BINDIR
bitfield
Bitfield

Check warning on line 46 in .github/actions/spelling/expect.txt

View workflow job for this annotation

GitHub Actions / Check Spelling 

`Bitfield` is ignored by check spelling because another more general variant is also in expect. (ignored-expect-variant)
bitmaps
bitshifts
bitwidth
Expand Down Expand Up @@ -216,7 +217,8 @@
endmacro
endraw
enduml
EPP

Check warning on line 220 in .github/actions/spelling/expect.txt

View workflow job for this annotation

GitHub Actions / Check Spelling 

`EPP` is ignored by check spelling because another more general variant is also in expect. (ignored-expect-variant)

Check warning

Code scanning / check-spelling

Ignored Expect Variant

[EPP](#security-tab) is ignored by check spelling because another more general variant is also in expect. \(ignored-expect-variant\)
epp
ERRORCHECK
errornum
ert
Expand All @@ -242,6 +244,7 @@
Ffs
fge
fgt
fhp
FILEDISPATCHER
FILEDISPATCHERCFG
FILEDOWNLINK
Expand Down Expand Up @@ -407,6 +410,7 @@
LOCALSTATEDIR
LOGGERRULES
LOGPACKET
lol
Lsb
lseek
LTK
Expand Down Expand Up @@ -439,6 +443,7 @@
MML
modbus
MOVEFILE
mpdu
Mpu
Msb
msc
Expand Down Expand Up @@ -736,7 +741,7 @@
TPP
trinomials
tts
Tumbar

Check warning on line 744 in .github/actions/spelling/expect.txt

View workflow job for this annotation

GitHub Actions / Check Spelling 

`Tumbar` is ignored by check spelling because another more general variant is also in expect. (ignored-expect-variant)
tumbar
typedef
typedef'ed
Expand All @@ -763,6 +768,7 @@
vcid
VCP
vcs
VCx
VFILE
VID
vla
Expand Down
Loading
Loading