Skip to content

Conversation

@mbbischoff
Copy link
Contributor

@mbbischoff mbbischoff commented Oct 31, 2025

Progress on #805.

Added the official New York UCSNC-1 petition form for individual adult name and/or sex designation change to the forms directory.

What changed?

Before I write the TypeScript, I just wanted to have @evadecker take a look at the first form, as I annotated it, and made sure I’m correctly following the guidelines set out in the forms README.

Added the official New York UCSNC-1 petition form for individual adult name and/or sex designation change to the forms directory.
@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2025

⚠️ No Changeset found

Latest commit: bc256c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mbbischoff mbbischoff requested a review from evadecker October 31, 2025 17:40
@github-actions github-actions bot added frontend CSS, HTML, and JS changes content Specific name change forms and data labels Oct 31, 2025
@cloudflare-workers-and-pages
Copy link

Deploying namesake with  Cloudflare Pages  Cloudflare Pages

Latest commit: bc256c5
Status: ✅  Deploy successful!
Preview URL: https://bf514a22.namesake-639.pages.dev
Branch Preview URL: https://ny-form-test.namesake-639.pages.dev

View logs

@mbbischoff mbbischoff marked this pull request as draft October 31, 2025 17:41
@github-actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 83.64% (🎯 80%)
🟰 ±0%
8731 / 10438
🟢 Statements 83.64% (🎯 80%)
🟰 ±0%
8731 / 10438
🟢 Functions 78.01% (🎯 75%)
🟰 ±0%
394 / 505
🟢 Branches 86.62% (🎯 80%)
🟰 ±0%
965 / 1114
File CoverageNo changed files found.
Generated in workflow #1128 for commit bc256c5 by the Vitest Coverage Report Action

@evadecker
Copy link
Member

Downloaded and gave a click through the form, the labels look good! Nice.

I will say that for the forms I wired up in the past it's been helpful to rely on test-driven development. So writing out the test cases you want to verify (fill out all these fields by default, fill out these fields if this conditional is checked, etc.) and then writing the TypeScript logic which gets them to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content Specific name change forms and data frontend CSS, HTML, and JS changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants