Skip to content

fix(ios): guard against nil iconImage in marker setImage callback #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mym0404 merged 2 commits into from
Apr 6, 2026
+3 −1
Merged

fix(ios): guard against nil iconImage in marker setImage callback #184

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c606352
fix(ios): guard against nil iconImage in marker setImage callback
spencer0124 Apr 4, 2026
cb208ea
fix(ios): restore marker alpha outside nil guard to prevent invisible…
spencer0124 Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ios/Overlay/Marker/RNCNaverMapMarker.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ - (void)setImage:(facebook::react::RNCNaverMapMarkerImageStruct)image {
_imageCanceller = nmap::getImage([self bridge], image, ^(NMFOverlayImage* _Nullable image) {
dispatch_async(dispatch_get_main_queue(), [self, image]() {
self.inner.alpha = 1;
self.inner.iconImage = image;
if (image) {
self.inner.iconImage = image;
Comment on lines +103 to +104
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore marker alpha when callback image is nil

setImage hides the marker with _inner.alpha = 0 before requesting the image, but this change now restores alpha only inside if (image). Because nmap::getImage can legally call back with nil (e.g., unsupported symbol or failed image resolution), the marker remains permanently transparent after the callback, so users see missing markers instead of a fallback/default icon. Keep alpha restoration outside the nil guard (and optionally preserve/set a fallback icon) to avoid this regression.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner

@mym0404 mym0404 Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify code as you suggested.

Copy link
Copy Markdown
Owner

@mym0404 mym0404 Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To use Codex here, create an environment for this repo.

}
self->_imageCanceller = nil;
[self ensureTouchHandler]; // Re-ensure touch handler after image is set
});
Expand Down
Loading