Open
Conversation
jgonggrijp
reviewed
Jun 2, 2023
Member
jgonggrijp
left a comment
jgonggrijp
left a comment
There was a problem hiding this comment.
Not very familiar with gitattributes, but this looks good at first sight, based on the documentation.
Is there any off chance that this could break anything for anyone?
|
Seems like eol=lf might not a good idea but considering I made that commit
almost exactly ten years ago, I have no idea what it was for.
…On Fri, Jun 2, 2023, 4:24 PM Julian Gonggrijp ***@***.***> wrote:
***@***.**** commented on this pull request.
Not very familiar with gitattributes, but this looks good at first sight,
based on the documentation.
Is there any off chance that this could break anything for anyone?
—
Reply to this email directly, view it on GitHub
<#145 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABXCQNXVMXV2ESWHMHXB33XJJY2PANCNFSM6AAAAAAYYYUJ5M>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
@jbboehr what makes it seem (to you) that eol=lf might not be a good idea? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstreaming a trivial change by @jbboehr from https://github.com/jbboehr/mustache-spec/commits/b96be9fd4c6d6984828d93169fe7e86d8a8aec2f, as used at https://github.com/jbboehr/libmustache.