Remove IDE0370

Author: mus65

.editorconfig

@@ -847,6 +847,11 @@ dotnet_diagnostic.IDE0300.severity = none
 # TODO: Discuss whether we want to start using this
 dotnet_diagnostic.IDE0301.severity = none
 
+# IDE0370: Remove unnecessary suppression
+#
+# This can lead to many false positives in different target frameworks.
+dotnet_diagnostic.IDE0370.severity = suggestion
+
 #### .NET Compiler Platform code style rules ####
 
 ### Language rules ###

src/Renci.SshNet/ScpClient.cs

@@ -254,9 +254,7 @@ public void Upload(Stream source, string path)
             using (var input = ServiceFactory.CreatePipeStream())
             using (var channel = Session.CreateChannelSession())
             {
-#pragma warning disable IDE0370 // Remove unnecessary suppression
                 channel.DataReceived += (sender, e) => input.Write(e.Data.Array!, e.Data.Offset, e.Data.Count);
-#pragma warning restore IDE0370 // Remove unnecessary suppression
                 channel.Closed += (sender, e) => input.Dispose();
                 channel.Open();
 
@@ -299,9 +297,7 @@ public void Upload(FileInfo fileInfo, string path)
             using (var input = ServiceFactory.CreatePipeStream())
             using (var channel = Session.CreateChannelSession())
             {
-#pragma warning disable IDE0370 // Remove unnecessary suppression
                 channel.DataReceived += (sender, e) => input.Write(e.Data.Array!, e.Data.Offset, e.Data.Count);
-#pragma warning restore IDE0370 // Remove unnecessary suppression
                 channel.Closed += (sender, e) => input.Dispose();
                 channel.Open();
 
@@ -347,9 +343,7 @@ public void Upload(DirectoryInfo directoryInfo, string path)
             using (var input = ServiceFactory.CreatePipeStream())
             using (var channel = Session.CreateChannelSession())
             {
-#pragma warning disable IDE0370 // Remove unnecessary suppression
                 channel.DataReceived += (sender, e) => input.Write(e.Data.Array!, e.Data.Offset, e.Data.Count);
-#pragma warning restore IDE0370 // Remove unnecessary suppression
                 channel.Closed += (sender, e) => input.Dispose();
                 channel.Open();
 
@@ -392,9 +386,7 @@ public void Download(string filename, FileInfo fileInfo)
             using (var input = ServiceFactory.CreatePipeStream())
             using (var channel = Session.CreateChannelSession())
             {
-#pragma warning disable IDE0370 // Remove unnecessary suppression
                 channel.DataReceived += (sender, e) => input.Write(e.Data.Array!, e.Data.Offset, e.Data.Count);
-#pragma warning restore IDE0370 // Remove unnecessary suppression
                 channel.Closed += (sender, e) => input.Dispose();
                 channel.Open();
 
@@ -434,9 +426,7 @@ public void Download(string directoryName, DirectoryInfo directoryInfo)
             using (var input = ServiceFactory.CreatePipeStream())
             using (var channel = Session.CreateChannelSession())
             {
-#pragma warning disable IDE0370 // Remove unnecessary suppression
                 channel.DataReceived += (sender, e) => input.Write(e.Data.Array!, e.Data.Offset, e.Data.Count);
-#pragma warning restore IDE0370 // Remove unnecessary suppression
                 channel.Closed += (sender, e) => input.Dispose();
                 channel.Open();
 
@@ -476,9 +466,7 @@ public void Download(string filename, Stream destination)
             using (var input = ServiceFactory.CreatePipeStream())
             using (var channel = Session.CreateChannelSession())
             {
-#pragma warning disable IDE0370 // Remove unnecessary suppression
                 channel.DataReceived += (sender, e) => input.Write(e.Data.Array!, e.Data.Offset, e.Data.Count);
-#pragma warning restore IDE0370 // Remove unnecessary suppression
                 channel.Closed += (sender, e) => input.Dispose();
                 channel.Open();
 

src/Renci.SshNet/Security/Cryptography/EcdsaKey.BclImpl.cs

@@ -65,10 +65,8 @@ public override bool Verify(byte[] input, byte[] signature)
             public override void Export(out byte[] qx, out byte[] qy)
             {
                 var parameter = Ecdsa.ExportParameters(includePrivateParameters: false);
-#pragma warning disable IDE0370 // Remove unnecessary suppression
                 qx = parameter.Q.X!;
                 qy = parameter.Q.Y!;
-#pragma warning restore IDE0370 // Remove unnecessary suppression
             }
 
             protected override void Dispose(bool disposing)

src/Renci.SshNet/SshCommand.cs

@@ -307,9 +307,7 @@ public Task ExecuteAsync(CancellationToken cancellationToken = default)
                 {
                     try
                     {
-#pragma warning disable IDE0370 // Remove unnecessary suppression
                         ((SshCommand)cmd!).CancelAsync();
-#pragma warning restore IDE0370 // Remove unnecessary suppression
                     }
                     catch
                     {
@@ -585,9 +583,7 @@ private void Channel_RequestReceived(object? sender, ChannelRequestEventArgs e)
 
         private void Channel_ExtendedDataReceived(object? sender, ChannelExtendedDataEventArgs e)
         {
-#pragma warning disable IDE0370 // Remove unnecessary suppression
             ExtendedOutputStream.Write(e.Data.Array!, e.Data.Offset, e.Data.Count);
-#pragma warning restore IDE0370 // Remove unnecessary suppression
 
             if (e.DataTypeCode == 1)
             {
@@ -597,9 +593,7 @@ private void Channel_ExtendedDataReceived(object? sender, ChannelExtendedDataEve
 
         private void Channel_DataReceived(object? sender, ChannelDataEventArgs e)
         {
-#pragma warning disable IDE0370 // Remove unnecessary suppression
             OutputStream.Write(e.Data.Array!, e.Data.Offset, e.Data.Count);
-#pragma warning restore IDE0370 // Remove unnecessary suppression
         }
 
         /// <summary>