fix Build with newer .NET 10 SDKs

The IDE0370 are a mess since they only affect certain target frameworks.
Maybe we should disable this one completely instead?

Also set a fixed SDK Version in CI so this doesn't randomly break again.

Author: mus65

.github/workflows/build.yml

@@ -16,6 +16,8 @@ jobs:
 
     - name: Setup .NET
       uses: actions/setup-dotnet@v5
+      with:
+        dotnet-version: '10.0.201'
 
     - name: Build Unit Tests .NET
       run: dotnet build -f net10.0 test/Renci.SshNet.Tests/
@@ -63,6 +65,8 @@ jobs:
 
     - name: Setup .NET
       uses: actions/setup-dotnet@v5
+      with:
+        dotnet-version: '10.0.201'
 
     - name: Build Solution
       run: dotnet build Renci.SshNet.slnx
@@ -114,6 +118,8 @@ jobs:
 
     - name: Setup .NET
       uses: actions/setup-dotnet@v5
+      with:
+        dotnet-version: '10.0.201'
 
     - name: Setup WSL2
       uses: Vampire/setup-wsl@6a8db447be7ed35f2f499c02c6e60ff77ef11278 # v6.0.0
@@ -156,6 +162,8 @@ jobs:
 
     - name: Setup .NET
       uses: actions/setup-dotnet@v5
+      with:
+        dotnet-version: '10.0.201'
 
     - name: Setup WSL2
       uses: Vampire/setup-wsl@6a8db447be7ed35f2f499c02c6e60ff77ef11278 # v6.0.0

src/Renci.SshNet/ForwardedPort.cs

@@ -105,10 +105,7 @@ protected virtual void StopPort(TimeSpan timeout)
             RaiseClosing();
 
             var session = Session;
-            if (session is not null)
-            {
-                session.ErrorOccured -= Session_ErrorOccurred;
-            }
+            session?.ErrorOccured -= Session_ErrorOccurred;
         }
 
         /// <summary>

src/Renci.SshNet/OrderedDictionary.netstandard.cs

@@ -234,7 +234,7 @@ public bool Remove(TKey key, [MaybeNullWhen(false)] out TValue value)
             }
 
             AssertConsistency();
-            value = default!;
+            value = default;
             return false;
         }
 

src/Renci.SshNet/ScpClient.cs

@@ -254,7 +254,9 @@ public void Upload(Stream source, string path)
             using (var input = ServiceFactory.CreatePipeStream())
             using (var channel = Session.CreateChannelSession())
             {
+#pragma warning disable IDE0370 // Remove unnecessary suppression
                 channel.DataReceived += (sender, e) => input.Write(e.Data.Array!, e.Data.Offset, e.Data.Count);
+#pragma warning restore IDE0370 // Remove unnecessary suppression
                 channel.Closed += (sender, e) => input.Dispose();
                 channel.Open();
 
@@ -297,7 +299,9 @@ public void Upload(FileInfo fileInfo, string path)
             using (var input = ServiceFactory.CreatePipeStream())
             using (var channel = Session.CreateChannelSession())
             {
+#pragma warning disable IDE0370 // Remove unnecessary suppression
                 channel.DataReceived += (sender, e) => input.Write(e.Data.Array!, e.Data.Offset, e.Data.Count);
+#pragma warning restore IDE0370 // Remove unnecessary suppression
                 channel.Closed += (sender, e) => input.Dispose();
                 channel.Open();
 
@@ -343,7 +347,9 @@ public void Upload(DirectoryInfo directoryInfo, string path)
             using (var input = ServiceFactory.CreatePipeStream())
             using (var channel = Session.CreateChannelSession())
             {
+#pragma warning disable IDE0370 // Remove unnecessary suppression
                 channel.DataReceived += (sender, e) => input.Write(e.Data.Array!, e.Data.Offset, e.Data.Count);
+#pragma warning restore IDE0370 // Remove unnecessary suppression
                 channel.Closed += (sender, e) => input.Dispose();
                 channel.Open();
 
@@ -386,7 +392,9 @@ public void Download(string filename, FileInfo fileInfo)
             using (var input = ServiceFactory.CreatePipeStream())
             using (var channel = Session.CreateChannelSession())
             {
+#pragma warning disable IDE0370 // Remove unnecessary suppression
                 channel.DataReceived += (sender, e) => input.Write(e.Data.Array!, e.Data.Offset, e.Data.Count);
+#pragma warning restore IDE0370 // Remove unnecessary suppression
                 channel.Closed += (sender, e) => input.Dispose();
                 channel.Open();
 
@@ -426,7 +434,9 @@ public void Download(string directoryName, DirectoryInfo directoryInfo)
             using (var input = ServiceFactory.CreatePipeStream())
             using (var channel = Session.CreateChannelSession())
             {
+#pragma warning disable IDE0370 // Remove unnecessary suppression
                 channel.DataReceived += (sender, e) => input.Write(e.Data.Array!, e.Data.Offset, e.Data.Count);
+#pragma warning restore IDE0370 // Remove unnecessary suppression
                 channel.Closed += (sender, e) => input.Dispose();
                 channel.Open();
 
@@ -466,7 +476,9 @@ public void Download(string filename, Stream destination)
             using (var input = ServiceFactory.CreatePipeStream())
             using (var channel = Session.CreateChannelSession())
             {
+#pragma warning disable IDE0370 // Remove unnecessary suppression
                 channel.DataReceived += (sender, e) => input.Write(e.Data.Array!, e.Data.Offset, e.Data.Count);
+#pragma warning restore IDE0370 // Remove unnecessary suppression
                 channel.Closed += (sender, e) => input.Dispose();
                 channel.Open();
 

src/Renci.SshNet/Security/Cryptography/EcdsaKey.BclImpl.cs

@@ -65,8 +65,10 @@ public override bool Verify(byte[] input, byte[] signature)
             public override void Export(out byte[] qx, out byte[] qy)
             {
                 var parameter = Ecdsa.ExportParameters(includePrivateParameters: false);
+#pragma warning disable IDE0370 // Remove unnecessary suppression
                 qx = parameter.Q.X!;
                 qy = parameter.Q.Y!;
+#pragma warning restore IDE0370 // Remove unnecessary suppression
             }
 
             protected override void Dispose(bool disposing)

src/Renci.SshNet/SshCommand.cs

@@ -307,7 +307,9 @@ public Task ExecuteAsync(CancellationToken cancellationToken = default)
                 {
                     try
                     {
+#pragma warning disable IDE0370 // Remove unnecessary suppression
                         ((SshCommand)cmd!).CancelAsync();
+#pragma warning restore IDE0370 // Remove unnecessary suppression
                     }
                     catch
                     {
@@ -583,7 +585,9 @@ private void Channel_RequestReceived(object? sender, ChannelRequestEventArgs e)
 
         private void Channel_ExtendedDataReceived(object? sender, ChannelExtendedDataEventArgs e)
         {
+#pragma warning disable IDE0370 // Remove unnecessary suppression
             ExtendedOutputStream.Write(e.Data.Array!, e.Data.Offset, e.Data.Count);
+#pragma warning restore IDE0370 // Remove unnecessary suppression
 
             if (e.DataTypeCode == 1)
             {
@@ -593,7 +597,9 @@ private void Channel_ExtendedDataReceived(object? sender, ChannelExtendedDataEve
 
         private void Channel_DataReceived(object? sender, ChannelDataEventArgs e)
         {
+#pragma warning disable IDE0370 // Remove unnecessary suppression
             OutputStream.Write(e.Data.Array!, e.Data.Offset, e.Data.Count);
+#pragma warning restore IDE0370 // Remove unnecessary suppression
         }
 
         /// <summary>

test/Renci.SshNet.Tests/Classes/AbstractionsTest.cs

@@ -1,5 +1,7 @@
-using Renci.SshNet.Abstractions;
-using Microsoft.VisualStudio.TestTools.UnitTesting;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+using Renci.SshNet.Abstractions;
+
 using System;
 using System.Threading;
 using System.Security.Cryptography;