added type hinting, document string, TODO statements, fixed small typ…#14
added type hinting, document string, TODO statements, fixed small typ…#14Relativiteit wants to merge 2 commits intomujin:masterfrom
Conversation
|
@rdiankov @ziyan @liuhuanjim013 @kanunikov-denys if no longer needed please close :) |
|
Currently we need to maintain Python2 as well. This pull request can be considered at least 1 year later. |
|
@cielavenir alright, is there anything else more pressing currently you need help on ? |
|
@felixvd @hemangandhi could you check? |
|
@cielavenir Do you have a pipeline ID? |
hemangandhi
left a comment
hemangandhi
left a comment
There was a problem hiding this comment.
Thanks for the type annotations!
|
@ziyan https://tiny.mujin.co.jp/qarwm However, since this typing will drop py2 explicitly, @felixvd must approve explicitly. |
felixvd
left a comment
felixvd
left a comment
There was a problem hiding this comment.
We have other Python3-style type annotation now, so LGTM!
|
ok to merge after minor syntax is corrected (this is year-old mr so @hemangandhi do you want to take a look at this? i pushed the same name branch to mujin) |
|
Could you please merge latest master? |
6 participants
add type hinting, document strings and typo in readme
Resolves#13Please test on linux machine before merging!!