[scheduler] Current time indicator circle bug#21816
Open
rita-codes wants to merge 7 commits intomui:masterfrom
Open
[scheduler] Current time indicator circle bug#21816rita-codes wants to merge 7 commits intomui:masterfrom
rita-codes wants to merge 7 commits intomui:masterfrom
Conversation
rita-codes
added
type: bug
|
Deploy preview: https://deploy-preview-21816--material-ui-x.netlify.app/ Bundle size report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #21728
Fixes the current time indicator circle in
EventTimelinebeing clipped and disappearing on vertical scroll.The circle was inside
EventsSubGridWrapperwhich hasoverflowY: clip(required becauseoverflowX: autoforcesoverflowY: visibleto compute as auto per CSS spec, and clip is the only way to prevent double vertical scrolling). This clipped the circle'stop: -4and caused it to scroll away vertically.The fix moves the circle to the events header cell, where it's outside the clipped container and unaffected by vertical scroll. Horizontal positioning is maintained via a
--events-scroll-leftCSS variable updated through the existing scroll sync hook.Before:
https://github.com/user-attachments/assets/5654ccbf-1148-4aab-9fd8-6eb57e4f4e46
Now:
https://github.com/user-attachments/assets/91d6bb09-d35f-4cb6-b3aa-4599736bd7c6