Fix integer overflow in FpsCounter initialization#2
Open
teleyos wants to merge 1 commit intomuhammad-fiaz:mainfrom
Open
Fix integer overflow in FpsCounter initialization#2teleyos wants to merge 1 commit intomuhammad-fiaz:mainfrom
teleyos wants to merge 1 commit intomuhammad-fiaz:mainfrom
Conversation
The `fps_counter` field was default-initialized with `.{}`, which left
`frame_times: [60]u32 = undefined` as garbage values. When `update()`
runs, it subtracts frame times from the current timestamp, causing
integer underflow if the garbage values exceed the current time.
This fix uses `animation.FpsCounter.init()` to properly zero-initialize
the frame times array.
Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FpsCounterdefault initialization to prevent integer overflowProblem
The
fps_counterfield inAppwas default-initialized with.{}:This leaves
frame_times: [60]u32 = undefinedas garbage values. Whenupdate()runs, it subtracts frame times from the current timestamp, which causes an integer underflow if the garbage values exceed the current time.Solution
Use
animation.FpsCounter.init()to properly zero-initialize the frame times array:Test plan
🤖 Generated with Claude Code