Manual: Remove reference to Matrix4.setRotationFromQuaternion()#33320
Merged
Mugen87 merged 1 commit intomrdoob:devfrom Apr 3, 2026
Merged
Manual: Remove reference to Matrix4.setRotationFromQuaternion()#33320Mugen87 merged 1 commit intomrdoob:devfrom
Mugen87 merged 1 commit intomrdoob:devfrom
Conversation
Kodub
changed the title
Mugen87
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Matrix Transformations page in the manual was still making references to
Matrix4.setRotationFromQuaternion()which has since been removed.This PR changes these examples to use
Matrix4.makeRotationFromQuaternion()instead.Note that
Object3D.setRotationFromQuaternion()still exists, but this is referring toMatrix4.setRotationFromQuaternion()which no longer exists.