Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #22312.
Fixed #22167.
Description
I'm recently trying to fix open issues with our loaders.
FBXLoaderis next.It's a challenging one because of the problematic/missing FBX spec definitions and the different interpretations in various importers/exporters. To improve
FBXLoaderI'm using the Blender FBX importer as a source.This particular PR fixes three bugs in
FBXLoaderwhen the skeleton is setup:bindSkeleton()after the scene traverse: This corrects the bind matrix for files without BindPose.SkinnedMesh.bind()from overwriting the bone inverses.With these fixes, the assets from #22312 and #22167 load like in Blender.
I've added both assets from the issues to the repo so we have more assets for testing. That is potentially more important than with other formats since we can't just rely on a official spec document. If this and upcoming PRs would introduce a regression, please open a new issue and share the problematic model so we can fix it. With more test assets, we can easier detect regressions.