player: save external subtitles in watch-later config #17330
+42
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Save manually added external subtitle files (via sub-add or drag-and-drop) to watch-later configuration so they are restored when reopening the file. - Add sub-files to the default watch-later-options list - Handle sub-files specially to write external subtitle paths - Skip auto-loaded subtitles (from sub-auto) as they'll reload automatically - Deduplicate watch-later-options before writing to handle -add on defaults
Contributor
|
Why open a new PR? You can rewrite git history on your other one. Dude, how do you not know how to use your own product? |
Author
|
I was made abundantly clear that the original PR is not up to mark. I have sorted out my changes and opened this PR with a clean commit history with the hope of getting it merged. |
Member
|
The sub-files-add/sub-files-append behavior is because that's a special option that purposely doesn't resolve. But that could be changed. I'm not sure how I feel about special casing external files that are dragged and dropped. That feels a bit wrong here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save manually added external subtitle files (via sub-add or drag-and-drop) to watch-later configuration so they are restored when reopening the file.
Read this before you submit this pull request:
https://github.com/mpv-player/mpv/blob/master/DOCS/contribute.md
Reading this link and following the rules will get your pull request reviewed
and merged faster. Nobody wants lazy pull requests.