Skip to content

Conversation

@Headcrabed
Copy link
Contributor

@Headcrabed Headcrabed commented Jan 15, 2026

Currently, Windows would enable SDR ACM by default on wide gamut monitors, while macOS and Wayland + Vulkan also always do color space conversion. So enable sdr_adjust_gamma by default to make it more suitable for most cases.

Currently, Windows would enable SDR ACM by default on wide gamut monitors,
while macOS and Wayland + Vulkan also always do color space conversion. So
enable `sdr_adjust_gamma` by default to make it more suitable for most
cases.

Signed-off-by: Shengyu Qu <wiagn233@outlook.com>
@kasper93
Copy link
Member

@na-na-hi doesn't like this. And I think given that SDR gamma input is mostly unknown/ambiguous, we can leave this as an option.

@kasper93 kasper93 added the priority:on-ice may be revisited later label Jan 21, 2026
@Headcrabed
Copy link
Contributor Author

Headcrabed commented Jan 21, 2026

@na-na-hi doesn't like this. And I think given that SDR gamma input is mostly unknown/ambiguous, we can leave this as an option.

I don't understand why not enable this by default. In cases that there's no global color management, mpv's color output is inaccurate unless user loads an ICC file or monitor is sRGB. So whether we enable it or not the color is always inaccurate by default on non-sRGB devices that do not have color management.

@kasper93
Copy link
Member

@na-na-hi doesn't like this. And I think given that SDR gamma input is mostly unknown/ambiguous, we can leave this as an option.

I don't understand why not enable this by default. In cases that there's no global color management, mpv's color output is inaccurate unless user loads an ICC file or monitor is sRGB. So whether we enable it or not the color is always inaccurate by default on non-sRGB devices that do not have color management.

If it's going to be "inaccurate", let's not make it more "wrong" that it is already. This is compatible with any other media player/viewer. No need to make random gamma conversions if both input and output are unknown. At least not by default, because it causes issues for not knowing users.

@Headcrabed
Copy link
Contributor Author

@na-na-hi doesn't like this. And I think given that SDR gamma input is mostly unknown/ambiguous, we can leave this as an option.

I don't understand why not enable this by default. In cases that there's no global color management, mpv's color output is inaccurate unless user loads an ICC file or monitor is sRGB. So whether we enable it or not the color is always inaccurate by default on non-sRGB devices that do not have color management.

If it's going to be "inaccurate", let's not make it more "wrong" that it is already. This is compatible with any other media player/viewer. No need to make random gamma conversions if both input and output are unknown. At least not by default, because it causes issues for not knowing users.

No, this is incompatible with Windows' default player(when ACM/HDR enabled) and also macOS quicktime. They all do gamma conversion by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:on-ice may be revisited later

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants