-
Notifications
You must be signed in to change notification settings - Fork 3.2k
video/out/gpu/video: change sdr_adjust_gamma default to yes
#17272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Currently, Windows would enable SDR ACM by default on wide gamut monitors, while macOS and Wayland + Vulkan also always do color space conversion. So enable `sdr_adjust_gamma` by default to make it more suitable for most cases. Signed-off-by: Shengyu Qu <wiagn233@outlook.com>
|
@na-na-hi doesn't like this. And I think given that SDR gamma input is mostly unknown/ambiguous, we can leave this as an option. |
I don't understand why not enable this by default. In cases that there's no global color management, mpv's color output is inaccurate unless user loads an ICC file or monitor is sRGB. So whether we enable it or not the color is always inaccurate by default on non-sRGB devices that do not have color management. |
If it's going to be "inaccurate", let's not make it more "wrong" that it is already. This is compatible with any other media player/viewer. No need to make random gamma conversions if both input and output are unknown. At least not by default, because it causes issues for not knowing users. |
No, this is incompatible with Windows' default player(when ACM/HDR enabled) and also macOS quicktime. They all do gamma conversion by default. |
Currently, Windows would enable SDR ACM by default on wide gamut monitors, while macOS and Wayland + Vulkan also always do color space conversion. So enable
sdr_adjust_gammaby default to make it more suitable for most cases.