This repository was archived by the owner on Feb 29, 2020. It is now read-only.
Bug 1539470 - Prevent tabs opened in the background from affecting th…#5077
Open
piatra wants to merge 2 commits intomozilla:masterfrom
Open
Bug 1539470 - Prevent tabs opened in the background from affecting th…#5077piatra wants to merge 2 commits intomozilla:masterfrom
piatra wants to merge 2 commits intomozilla:masterfrom
Conversation
…e CFR Pin Tab visits counter
k88hudson
reviewed
Sep 11, 2019
Contributor
k88hudson
left a comment
k88hudson
left a comment
There was a problem hiding this comment.
Is this still something we want to land?
Contributor
Author
|
The issue still happens:
But it's not that important we could also close this. |
Mardak
reviewed
Sep 12, 2019
| */ | ||
| function isFocusedTab(aBrowser, aLocationURI) { | ||
| try { | ||
| if (aBrowser.ownerGlobal.gBrowser.currentURI.spec === aLocationURI.spec) { |
Member
There was a problem hiding this comment.
Pretty sure you can do aBrowser === aBrowser.ownerGlobal.gBrowser.selectedBrowser and not sure if you need a try/catch for nsIURI stuff anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e CFR Pin Tab visits counter
Note: This is only required for the pinned tabs trigger. For addon recommendations if you open a tab in the background you won't get a notification and no impression is counted.
TODO: