Refactor FXIOS-15402 [Sentry] Update to 0.9.10 & disable network breadcrumbs#33020
Refactor FXIOS-15402 [Sentry] Update to 0.9.10 & disable network breadcrumbs#33020mattreaganmozilla wants to merge 3 commits intomozilla-mobile:mainfrom
Conversation
🧹 Tidy commitJust 1 file(s) touched. Thanks for keeping it clean and review-friendly! 💬 Description craftsmanGreat PR description! Reviewers salute you 🫡 ✅ New file code coverageNo new file detected so code coverage gate wasn't ran. Generated by 🚫 Danger Swift against a206532 |
|
I checked and we're kind of outdated as well with the Sentry versions. Latest one is 9.10.0 and we are on 8.36.0. The documentation could be untrue for the 8.36.0 version? It's probably worth upgrading the version as well. What do you think? |
|
Documentation link is enableNetworkBreadcrumbs |
8.36 is surprisingly old. Do we have a formal process for upgrading these types of packages? I'm assuming we use |
📜 Tickets
Jira ticket
Github ticket
💡 Description
Still investigating but wanted to get a PR up so we have a place to discuss & document. This PR updates Sentry to 0.9.10 and disables breadcrumb logging. We're already disabling
enableCaptureFailedRequests🤔 , the only other culprit I could find wasenableNetworkBreadcrumbs. However the documentation states that since network breadcrumbs requires swizzling, the fact that we setenableSwizzlingto false should've meant we're not sending breadcrumbs.📝 Checklist