Skip to content

Refactor FXIOS-15402 [Sentry] Update to 0.9.10 & disable network breadcrumbs#33020

Open
mattreaganmozilla wants to merge 3 commits intomozilla-mobile:mainfrom
mattreaganmozilla:mr/15402
Open

Refactor FXIOS-15402 [Sentry] Update to 0.9.10 & disable network breadcrumbs#33020
mattreaganmozilla wants to merge 3 commits intomozilla-mobile:mainfrom
mattreaganmozilla:mr/15402

Conversation

@mattreaganmozilla
Copy link
Copy Markdown
Collaborator

@mattreaganmozilla mattreaganmozilla commented Apr 9, 2026

📜 Tickets

Jira ticket
Github ticket

💡 Description

Still investigating but wanted to get a PR up so we have a place to discuss & document. This PR updates Sentry to 0.9.10 and disables breadcrumb logging. We're already disabling enableCaptureFailedRequests 🤔 , the only other culprit I could find was enableNetworkBreadcrumbs. However the documentation states that since network breadcrumbs requires swizzling, the fact that we set enableSwizzling to false should've meant we're not sending breadcrumbs.

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@mattreaganmozilla mattreaganmozilla requested a review from a team as a code owner April 9, 2026 21:02
@lmarceau lmarceau changed the title [FXIOS-15402] Disable network breadcrumbs Refactor FXIOS-15402 [Sentry] Disable network breadcrumbs Apr 9, 2026
@mobiletest-ci-bot
Copy link
Copy Markdown

🧹 Tidy commit

Just 1 file(s) touched. Thanks for keeping it clean and review-friendly!

💬 Description craftsman

Great PR description! Reviewers salute you 🫡

✅ New file code coverage

No new file detected so code coverage gate wasn't ran.

Generated by 🚫 Danger Swift against a206532

@lmarceau
Copy link
Copy Markdown
Contributor

lmarceau commented Apr 9, 2026

I checked and we're kind of outdated as well with the Sentry versions. Latest one is 9.10.0 and we are on 8.36.0. The documentation could be untrue for the 8.36.0 version? It's probably worth upgrading the version as well. What do you think?

@lmarceau
Copy link
Copy Markdown
Contributor

lmarceau commented Apr 9, 2026

Documentation link is enableNetworkBreadcrumbs

@mattreaganmozilla
Copy link
Copy Markdown
Collaborator Author

I checked and we're kind of outdated as well with the Sentry versions. Latest one is 9.10.0 and we are on 8.36.0. The documentation could be untrue for the 8.36.0 version? It's probably worth upgrading the version as well. What do you think?

8.36 is surprisingly old. Do we have a formal process for upgrading these types of packages? I'm assuming we use Exact version to avoid unexpected changes, but that also would mean if we decide to update we'll probably need to perform some smoketesting by the Eng team and reach out QA for regression testing? I can coordinate that if we think it's a good time to update.

@mattreaganmozilla mattreaganmozilla added the Do Not Merge ⛔️ This issue is a work in progress and is not ready to land label Apr 10, 2026
@mattreaganmozilla mattreaganmozilla changed the title Refactor FXIOS-15402 [Sentry] Disable network breadcrumbs Refactor FXIOS-15402 [Sentry] Update to 0.9.10 & disable network breadcrumbs Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge ⛔️ This issue is a work in progress and is not ready to land

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants