Skip to content

Add FXIOS-15370 [Newsfeed Categories] Create reusable chip button component#33015

Open
Foxbolts wants to merge 2 commits intomainfrom
fb/FXIOS-15370_chip-button-component
Open

Add FXIOS-15370 [Newsfeed Categories] Create reusable chip button component#33015
Foxbolts wants to merge 2 commits intomainfrom
fb/FXIOS-15370_chip-button-component

Conversation

@Foxbolts
Copy link
Copy Markdown
Collaborator

@Foxbolts Foxbolts commented Apr 9, 2026

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Create a reusable ChipButton to be used for the newsfeed category picker

🎥 Demos

Light Dark
Screenshot 2026-04-09 at 1 35 51 PM Screenshot 2026-04-09 at 1 35 45 PM

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@Foxbolts Foxbolts requested a review from adudenamedruby April 9, 2026 17:47
@Foxbolts Foxbolts requested a review from a team as a code owner April 9, 2026 17:47
@mobiletest-ci-bot
Copy link
Copy Markdown

mobiletest-ci-bot commented Apr 9, 2026

Warnings
⚠️

❌ New file code coverage

The following new file(s) are below their scaled coverage:

File Coverage Required
BrowserKit/Sources/ComponentLibrary/Buttons/ChipButton.swift 0.0% 59.5%
BrowserKit/Sources/ComponentLibrary/Buttons/ChipButtonViewModel.swift 0.0% 47.3%

Bypass label ignore-code-coverage detected — reporting as warnings only for this PR.

Messages
📖 Project coverage: 41.03%

🥇 Perfect PR size

Smaller PRs are easier to review. Thanks for making life easy for reviewers! ✨

Client.app: Coverage: 39.41

File Coverage
TabTrayPanelSwipePalette.swift 0.0% ⚠️

ComponentLibrary: Coverage: 25.78

File Coverage
ChipButtonViewModel.swift 0.0% ⚠️
ChipButton.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 83caae7

@Foxbolts Foxbolts added the ignore-code-coverage Use this label with a comment and tag the unit tests owners label Apr 9, 2026
@Foxbolts
Copy link
Copy Markdown
Collaborator Author

Foxbolts commented Apr 9, 2026

Added ignore-code-coverage as ChipButton is all UI, and the ChipButtonViewModel has no business logic

Tagging @mozilla-mobile/fxios-unit-test-owners for approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-code-coverage Use this label with a comment and tag the unit tests owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants