Bugfix FXIOS-15400 [Translation Phase 2] Action sheet UX improvements – bold title, smart placement, single-language auto-translate#33013
Draft
razvanlitianu wants to merge 4 commits intomainfrom
Conversation
- Bold title using DefaultDynamicFontHelper for Dynamic Type support - Remove popover arrow on iPad when anchored to toolbar button with up/down directions - Skip view fallback source on iOS 26+ to let UIKit handle presentation - Auto-translate directly when user has exactly one preferred language
UIKit only creates the title label when alert.title is non-nil, so setValue(forKey: attributedTitle) had no effect without it.
…uage check Aligns middleware with coordinator logic by using the same TranslationConfiguration.isMultiLanguageFlow flag instead of checking languages.count after filtering against supported languages.
🧹 Tidy commitJust 2 file(s) touched. Thanks for keeping it clean and review-friendly! 🦊 BrowserViewController CheckWe’re tracking the size of
✅ New file code coverageNo new file detected so code coverage gate wasn't ran. Client.app: Coverage: 39.43
Generated by 🚫 Danger Swift against 707b8b6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
🎥 Demos
Demo
📝 Checklist