Skip to content

Bugfix FXIOS-15386 [Translations Phase 2] Auto-translate prompt Enable button not visible at large dynamic text sizes#33003

Open
razvanlitianu wants to merge 1 commit intomainfrom
rlitianu/fxios-15386-auto-translate-dynamic-text
Open

Bugfix FXIOS-15386 [Translations Phase 2] Auto-translate prompt Enable button not visible at large dynamic text sizes#33003
razvanlitianu wants to merge 1 commit intomainfrom
rlitianu/fxios-15386-auto-translate-dynamic-text

Conversation

@razvanlitianu
Copy link
Copy Markdown
Collaborator

@razvanlitianu razvanlitianu commented Apr 9, 2026

📜 Tickets

Jira ticket
Github issue

💡 Description

Wrapped messageLabel and enableButton in a nested messageEnableStack. At accessibility content size categories, this inner stack switches to a vertical axis so the button drops below the message text. The close button stays top-right at all sizes. Layout updates live via UIContentSizeCategory.didChangeNotification.

🎥 Demos

IMG_0359
Before After
Demo

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

…ble button not visible at large dynamic text sizes
@razvanlitianu razvanlitianu marked this pull request as ready for review April 9, 2026 10:14
@razvanlitianu razvanlitianu requested a review from a team as a code owner April 9, 2026 10:14
@mobiletest-ci-bot
Copy link
Copy Markdown

Messages
📖 Project coverage: 41.1%

🧹 Tidy commit

Just 1 file(s) touched. Thanks for keeping it clean and review-friendly!

💬 Description craftsman

Great PR description! Reviewers salute you 🫡

✅ New file code coverage

No new file detected so code coverage gate wasn't ran.

Client.app: Coverage: 39.4

File Coverage
AutoTranslatePromptView.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 8c1e892

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants