Skip to content

Bugfix FXIOS-15248 Tab swiping preview showing up suddenly after swipe#33000

Merged
rilury merged 1 commit intomainfrom
riordan/FXIOS-15248_Tab-swiping-preview-showing-up-suddenly-after-swipe
Apr 10, 2026
Merged

Bugfix FXIOS-15248 Tab swiping preview showing up suddenly after swipe#33000
rilury merged 1 commit intomainfrom
riordan/FXIOS-15248_Tab-swiping-preview-showing-up-suddenly-after-swipe

Conversation

@rilury
Copy link
Copy Markdown
Collaborator

@rilury rilury commented Apr 9, 2026

📜 Tickets

Jira ticket
Github issue

💡 Description

This PR fixes a tab-swipe preview visibility issue where preview showed up after swipe.
Now the preview is always explicitly hidden and reset (isHidden = true, alpha = 1) after swipe completion.

🎥 Demos

Before After
Demo

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@rilury rilury requested a review from yoanarios April 9, 2026 07:36
@mobiletest-ci-bot
Copy link
Copy Markdown

Messages
📖 Project coverage: 41.09%

🧹 Tidy commit

Just 1 file(s) touched. Thanks for keeping it clean and review-friendly!

✅ New file code coverage

No new file detected so code coverage gate wasn't ran.

Client.app: Coverage: 39.41

File Coverage
AddressBarPanGestureHandler.swift 26.25% ⚠️

Generated by 🚫 Danger Swift against aff6000

@rilury rilury marked this pull request as ready for review April 9, 2026 09:40
@rilury rilury requested a review from a team as a code owner April 9, 2026 09:40
Copy link
Copy Markdown
Contributor

@yoanarios yoanarios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rilury rilury merged commit 0ab9438 into main Apr 10, 2026
9 checks passed
@rilury rilury deleted the riordan/FXIOS-15248_Tab-swiping-preview-showing-up-suddenly-after-swipe branch April 10, 2026 05:45
@github-actions
Copy link
Copy Markdown
Contributor

🚀 PR merged to main, targeting version: 150.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants