Add FXIOS-15343 [AI Kill Switch] Add nimbus context value for disabling AI by Cramsden · Pull Request #32929 · mozilla-mobile/firefox-ios

Cramsden · 2026-04-06T19:22:09Z

📜 Tickets

💡 Description

Add userDisabledAI to RecordedNimbusContext. So that users are excluded from additional AI feature experiments. Similar android PR https://phabricator.services.mozilla.com/D291861

📝 Checklist

I filled in the ticket numbers and a description of my work
I updated the PR name to follow our PR naming guidelines
I ensured unit tests pass and wrote tests for new code
If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
If adding telemetry, I read the data stewardship requirements and will request a data review
If adding or modifying strings, I read the guidelines and will request a string review from l10n
If needed, I updated documentation and added comments to complex code

freshstrangemusic · 2026-04-06T19:29:09Z

firefox-ios/Client/Glean/probes/metrics.yaml

      - 'https://github.com/mozilla-mobile/firefox-ios/issues/23736'
+      - 'https://mozilla-hub.atlassian.net/browse/FXIOS-15343'
    data_reviews:
      - 'https://github.com/mozilla-mobile/firefox-ios/pull/23737#issuecomment-2541639916'


Please add a data-review request to this ticket and flag a data steward c.f. https://wiki.mozilla.org/Data_Collection

Please add the completed data-review to the data_reviews section (following the format of the existing link, i.e., link to the comment where the data review is granted.)

mobiletest-ci-bot · 2026-04-06T19:35:42Z

	Warnings
⚠️	Detected telemetry changes in: firefox-ios/Client/Glean/probes/metrics.yaml (cc @ih-codes @adudenamedruby)

	Messages
📖	Project coverage: 41.05%

💪 Quality guardian

1 tests files modified. You're a champion of test coverage! 🚀

🧹 Tidy commit

Just 5 file(s) touched. Thanks for keeping it clean and review-friendly!

📊 Telemetry changes detected

Changes with additions detected in Glean telemetry files:
• firefox-ios/Client/Glean/probes/metrics.yaml

Any additions to telemetry will require a data review. Please fill out a data review form (found in the data review repo) as necessary, and tag @adudenamedruby for data review.

✅ New file code coverage

No new file detected so code coverage gate wasn't ran.

Client.app: Coverage: 39.39

File	Coverage
Experiments.swift	79.34%	✅
ProfilePrefsReader.swift	93.75%	✅
RecordedNimbusContext.swift	94.96%	✅

Generated by 🚫 Danger Swift against 426f94f

Cramsden · 2026-04-07T14:37:06Z

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

What questions will you answer with this data?
We want to be able to track if a user has opted out of AI features so that they are not enrolled in any new AI Feature experiments.
Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements? Some example responses:

Provides information essential for making sure our users have the Firefox iOS experience they configured, even without an fxa account and as new features roll out.

What alternative methods did you consider to answer these questions? Why were they not sufficient?
You could tie this information to an fxa account but that requires login which would greatly decrease the experience for folks who don't have an fxa account.
Can current instrumentation answer these questions?
yes
List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description	Data Collection Category	Tracking Bug #
recorded_nimbus_context.user_disabled_ai	2	https://mozilla-hub.atlassian.net/browse/FXIOS-15343

Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
This collection is documented in the Glean Dictionary at https://dictionary.telemetry.mozilla.org/
How long will this data be collected? Choose one of the following:

for the life of the AI Kill Switch Feature, probably permanently

What populations will you measure?

New users and existing users

If this data collection is default on, what is the opt-out mechanism for users?
User has the general option of disable telemetry or/and studies. They could also turn the AI Kill Switch feature off.
Please provide a general description of how you will analyze this data.
Where do you intend to share the results of your analysis?
This is more of a configuration to make sure that the user choice is persisted for new features. There isn't anything to analyze.
Is there a third-party tool (i.e. not Glean or Telemetry) that you are proposing to use for this data collection? If so:

No

Cramsden · 2026-04-07T14:38:16Z

@freshstrangemusic data review added

freshstrangemusic · 2026-04-07T14:53:53Z

firefox-ios/Client/Glean/probes/metrics.yaml

+      - 'https://mozilla-hub.atlassian.net/browse/FXIOS-15343'
    data_reviews:
      - 'https://github.com/mozilla-mobile/firefox-ios/pull/23737#issuecomment-2541639916'
+      - 'https://github.com/mozilla-mobile/firefox-ios/pull/32929'


We still need the actual data review to be granted. This is just the request

When a data steward signs off on this, please update the URL here to point to the comment they leave.

Because * The risk_ai flag on experiments currently only generates targeting for Desktop using the `browser.ai.control.default` preference * Fenix ([Bug 2028993](https://bugzilla.mozilla.org/show_bug.cgi?id=2028993) / [D291861](https://phabricator.services.mozilla.com/D291861)) and iOS (mozilla-mobile/firefox-ios#32929) have added `user_disabled_ai` to their RecordedNimbusContext, shipping in v151 * Experiments using AI features need to exclude mobile users who have opted out of AI functionality This commit * Adds `user_disabled_ai == false` targeting expression when `risk_ai` is true and the application is Fenix or iOS * Adds version validation requiring >= v151 for mobile apps with `risk_ai` enabled * Adds model and serializer tests for both Fenix and iOS Fixes #15160

adudenamedruby · 2026-04-08T13:31:21Z

r+

Data Review Form

1) Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, telemetry is documented at https://dictionary.telemetry.mozilla.org/apps/firefox_ios

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, Firefox iOS provides data controls in the app settings

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

This will be reviewed by a data-steward on the Firefox iOS team (@adudenamedruby) yearly.

4) Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Type 2

5) Is the data collection request for default-on or default-off?

Default on

6) Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

7) Is the data collection covered by the existing Firefox privacy notice?

Yes

8) Does the data collection use a third-party collection tool?

No

ih-codes

Might also be useful to add a unit test for the false case if you think it makes sense!

I'll approve from a telemetry naming perspective.

ih-codes · 2026-04-08T16:03:05Z

firefox-ios/Client/Glean/probes/metrics.yaml

          type: boolean
        has_accepted_terms_of_use:
          type: boolean
+        user_disabled_ai:


Maybe we should continue with the has/is boolean naming pattern? 🤔 has_user_disabled_ai ?

I went back and forth on this one... I wasn't sure if it mattered at all if our naming patterns were consistent with Android's implementation https://phabricator.services.mozilla.com/D291861

Ahh... well, the probe wasn't named by us anyway, so even though we prefer iOS naming consistency, I don't feel strongly on this. If every single other field here already matches between iOS and Android let's keep with that.

mergify · 2026-04-09T18:58:00Z

This pull request has conflicts when rebasing. Could you fix it @Cramsden? 🙏

Add nimbus context value for disabling ai

55f2c70

Cramsden requested a review from a team as a code owner April 6, 2026 19:22

Cramsden requested review from adudenamedruby, ih-codes and razvanlitianu and removed request for razvanlitianu April 6, 2026 19:22

freshstrangemusic reviewed Apr 6, 2026

View reviewed changes

add new data review

426f94f

freshstrangemusic reviewed Apr 7, 2026

View reviewed changes

This was referenced Apr 7, 2026

Add iOS and Fenix AI killswitch flags mozilla/experimenter#15157

Closed

Add user_disabled_ai targeting support for Fenix and iOS mozilla/experimenter#15160

Closed

feat(nimbus): add user_disabled_ai targeting for Fenix and iOS mozilla/experimenter#15162

Merged

ih-codes approved these changes Apr 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add FXIOS-15343 [AI Kill Switch] Add nimbus context value for disabling AI#32929

Add FXIOS-15343 [AI Kill Switch] Add nimbus context value for disabling AI#32929
Cramsden wants to merge 2 commits intomainfrom
cr/fxios-15343_add-nimbus-ping-for-ai-features

Cramsden commented Apr 6, 2026 •

edited

Loading

Uh oh!

freshstrangemusic Apr 6, 2026

Uh oh!

mobiletest-ci-bot commented Apr 6, 2026 •

edited

Loading

Uh oh!

Cramsden commented Apr 7, 2026

Uh oh!

Cramsden commented Apr 7, 2026

Uh oh!

freshstrangemusic Apr 7, 2026

Uh oh!

adudenamedruby commented Apr 8, 2026 •

edited

Loading

Uh oh!

ih-codes left a comment

Uh oh!

ih-codes Apr 8, 2026

Uh oh!

Cramsden Apr 8, 2026

Uh oh!

ih-codes Apr 8, 2026

Uh oh!

mergify bot commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Cramsden commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Tickets

💡 Description

📝 Checklist

Uh oh!

freshstrangemusic Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

mobiletest-ci-bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💪 Quality guardian

🧹 Tidy commit

📊 Telemetry changes detected

✅ New file code coverage

Client.app: Coverage: 39.39

Uh oh!

Cramsden commented Apr 7, 2026

Request for data collection review form

Uh oh!

Cramsden commented Apr 7, 2026

Uh oh!

freshstrangemusic Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

adudenamedruby commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Data Review Form

Uh oh!

ih-codes left a comment

Choose a reason for hiding this comment

Uh oh!

ih-codes Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Cramsden Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

ih-codes Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Cramsden commented Apr 6, 2026 •

edited

Loading

mobiletest-ci-bot commented Apr 6, 2026 •

edited

Loading

adudenamedruby commented Apr 8, 2026 •

edited

Loading