Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the incremental removal of rubocop:todo directives and applies RuboCop-driven style cleanups across build/test tooling and example scripts.
Changes:
- Cleans up
Rakefilestyle (load path usage, task syntax, constant freezing) and adds/clarifies task descriptions. - Modernizes gem/gemfile headers and formatting (frozen string literal,
__dir__, quoting/require_relative style). - Updates RuboCop configuration related to filename enforcement.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Rakefile | Removes rubocop:todo, refactors spec organization helper, adjusts load path usage and task definitions, adds task descriptions. |
| mongo.gemspec | Removes rubocop:todo, modernizes lib path resolution and formatting, adds MFA metadata. |
| gemfiles/zstd_compression.gemfile | Removes rubocop:todo, adds frozen string literal header and normalizes quoting/require_relative. |
| gemfiles/snappy_compression.gemfile | Removes rubocop:todo, adds frozen string literal header and normalizes quoting/require_relative. |
| gemfiles/mongo_kerberos.gemfile | Removes rubocop:todo, adds frozen string literal header and normalizes quoting/require_relative. |
| gemfiles/bson_min.gemfile | Removes rubocop:todo, adds frozen string literal header and normalizes quoting/require_relative. |
| gemfiles/bson_master.gemfile | Removes rubocop:todo, adds frozen string literal header and normalizes quoting/require_relative. |
| gemfiles/bson_4-stable.gemfile | Removes rubocop:todo, adds frozen string literal header and normalizes quoting/require_relative. |
| Gemfile | Removes rubocop:todo header. |
| examples/query.rb | Removes rubocop:todo and reformats queries. |
| examples/index.rb | Removes rubocop:todo and prints ok? status after index creation. |
| examples/delete.rb | Removes rubocop:todo header. |
| examples/create.rb | Removes rubocop:todo and reformats insert example (including zipcode as a string). |
| examples/aggregate.rb | Removes rubocop:todo and reformats aggregation pipelines. |
| .rubocop.yml | Disables Naming/FileName cop globally with an explanatory comment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incrementally working through removing
rubocop:todofrom the files.