Skip to content

Some minor rubocop appeasement#3003

Open
jamis wants to merge 3 commits intomongodb:masterfrom
jamis:20260323-rubocop-work
Open

Some minor rubocop appeasement#3003
jamis wants to merge 3 commits intomongodb:masterfrom
jamis:20260323-rubocop-work

Conversation

@jamis
Copy link
Contributor

@jamis jamis commented Mar 23, 2026

Incrementally working through removing rubocop:todo from the files.

Copilot AI review requested due to automatic review settings March 23, 2026 18:11
@jamis jamis requested a review from a team as a code owner March 23, 2026 18:11
@jamis jamis requested a review from comandeo-mongo March 23, 2026 18:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the incremental removal of rubocop:todo directives and applies RuboCop-driven style cleanups across build/test tooling and example scripts.

Changes:

  • Cleans up Rakefile style (load path usage, task syntax, constant freezing) and adds/clarifies task descriptions.
  • Modernizes gem/gemfile headers and formatting (frozen string literal, __dir__, quoting/require_relative style).
  • Updates RuboCop configuration related to filename enforcement.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
Rakefile Removes rubocop:todo, refactors spec organization helper, adjusts load path usage and task definitions, adds task descriptions.
mongo.gemspec Removes rubocop:todo, modernizes lib path resolution and formatting, adds MFA metadata.
gemfiles/zstd_compression.gemfile Removes rubocop:todo, adds frozen string literal header and normalizes quoting/require_relative.
gemfiles/snappy_compression.gemfile Removes rubocop:todo, adds frozen string literal header and normalizes quoting/require_relative.
gemfiles/mongo_kerberos.gemfile Removes rubocop:todo, adds frozen string literal header and normalizes quoting/require_relative.
gemfiles/bson_min.gemfile Removes rubocop:todo, adds frozen string literal header and normalizes quoting/require_relative.
gemfiles/bson_master.gemfile Removes rubocop:todo, adds frozen string literal header and normalizes quoting/require_relative.
gemfiles/bson_4-stable.gemfile Removes rubocop:todo, adds frozen string literal header and normalizes quoting/require_relative.
Gemfile Removes rubocop:todo header.
examples/query.rb Removes rubocop:todo and reformats queries.
examples/index.rb Removes rubocop:todo and prints ok? status after index creation.
examples/delete.rb Removes rubocop:todo header.
examples/create.rb Removes rubocop:todo and reformats insert example (including zipcode as a string).
examples/aggregate.rb Removes rubocop:todo and reformats aggregation pipelines.
.rubocop.yml Disables Naming/FileName cop globally with an explanatory comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants