feat(csi-1953): optimize post/put quotes handling#444
Open
Conversation
geka-evk
requested review from
bushjames,
elnyry-sam-k,
gibaros,
kalinkrustev,
kleyow,
oderayi,
shashi165 and
vijayg10
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request optimizes quote handling in the POST/PUT operations by parallelizing database operations and improving logging efficiency.
Key Changes:
- Parallelized multiple database operations using Promise.all to improve performance in quote creation and update flows
- Replaced
JSON.stringifywithUtil.getCircularReplacer()calls with thefast-safe-stringifylibrary for safer and more efficient serialization - Extracted quote creation logic into a private method
#createQuoteInDbfor better code organization
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/model/quotes.js | Optimized database operations with Promise.all and created private method for quote creation; replaced circular-safe JSON.stringify with fast-safe-stringify |
| src/model/fxQuotes.js | Replaced JSON.stringify with circular replacer calls with fast-safe-stringify |
| src/model/bulkQuotes.js | Replaced JSON.stringify with circular replacer calls with fast-safe-stringify |
| src/lib/util.js | Updated calculateRequestHash to use fast-safe-stringify |
| src/handlers/QuotingHandler.js | Improved logging format to use structured logging instead of JSON.stringify |
| src/data/database.js | Enhanced logging to include both quoteId and transactionReferenceId |
| test/unit/model/quotes.test.js | Updated test data to use consistent transactionId variable; commented out two test cases and one assertion count |
| package-lock.json | Removed "dev": true markers from development dependencies (unintended change) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.