[color] Very generic colors: Rgb, Hsv and Gray#781
[color] Very generic colors: Rgb, Hsv and Gray#781TomSaw wants to merge 2 commits intomodm-io:developfrom
Conversation
984e341 to
e5c2b15
Compare
4bb19da to
c5e651d
Compare
|
This is ready for a first review @salkinium |
salkinium
left a comment
There was a problem hiding this comment.
So far I like it a lot, very nice design with the generic bit width!
67b645a to
7498e57
Compare
7d115fe to
4bb51f8
Compare
|
Apologize my enduring "push --force" thunderstorm. I'm transitioning from poke mode to test local, push after success mode 😬 Tests passed @salkinium! What's left is a good solution for the |
1775d67 to
d31c8f9
Compare
76a0520 to
623b9db
Compare
d4aa227 to
d30e633
Compare
cb45e64 to
ce8a2d6
Compare
|
These colors have been proven in the field. Adding code snippets to the docs (
|
I'll try to find some time tomorrow to look at the PR. |
|
Wanna get some stuff off the table. This PR feels robust, if you find a minute @salkinium 😅... |
salkinium
left a comment
There was a problem hiding this comment.
I'm fine with these changes, modulo my doc comment.
I'm two weeks from handing in my thesis, so cannot give you a technical review, but if @chris-durand approves this PR, I'll merge it.
| Only the Hue component of Hsv ColorType wraps around just like integers do. | ||
|
|
||
| ## Flexible Widgets | ||
| - [ ] Complete this snippet and make the code actually working |
There was a problem hiding this comment.
?
We generally don't promise future code in the documentation, cos we usually don't get it done in time ;-P
|
@TomSaw Did you see what I wrote in #781 (comment) ? The discussion got so lengthy that github hides most of it by default 😅 |
Nope. Totally missed that and check it tomorrow. |
ce9bf1f to
f3b91c9
Compare
|
I'm still very interested in merging this, unfortunately, I've completely lost the overview of the review. I think it's almost done, perhaps you want to address the least comments and then we can merge it? |
|
Hey there. Yes it was almost done. Only chris requested to extract the "arbitrary integer" logic into its own class for good reasons, see #781 (comment) and #781 (comment) Simple task but then, a strong force pulled me into another universe. One with a ton of PHP actually 🤕 I've just read the processing::fibers readme and it sounds gorgeous 🤩 congrats for completing this! |
|
Nothing changed yet.. just cleaned up the tree |
These Colors may be used on their own. F.e. passed to a colored LED driver or being emitted by color-sensor drivers.
They also represent single pixels for
modm::graphic::Bufferandmodm::graphic::Display(Work in progress, see feature/rewrite-graphicFeatures
color::Gray. Same forcolor::Rgbandcolor::Hsvcause they're made from 3xcolor::Graymodm::graphic::Bufferandmodm::graphic::Display(Coming soon, see feature/rewrite-graphicTODO
ProportionalUnsigned::ProportionalUnsigned(T value)