fix tests after typescript-sdk became modulized #475
Closed
Fuud wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
fix tests after typescript-sdk became modulized #475Fuud wants to merge 1 commit intomodelcontextprotocol:mainfrom
Fuud wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Contributor
|
Thank you, @Fuud for PR, but let's make it a bit differently.
|
Contributor
Author
Contributor
|
Thank you @Fuud. I am looking at the typescript tests right now. You may have a look at conformance tests, they're got broken. We should use package.json and specific versions of typescript dependencies to avoid unexpected changes. |
7 tasks
Contributor
kpavlov
added a commit
that referenced
this pull request
Jan 10, 2026
…tion tests (#477) # refactor(test): add centralized TypeScript server factory for integration tests - Create TypeScriptServer class for managing TypeScript MCP servers - Add dedicated typescript/ directory with server infrastructure - Refactor TsTestBase to use TypeScriptServer for stdio transport - Extract TypeScript test tools (greet, multi-greet, prompts, resources) - Use npx tsx for direct execution (better performance than npm run) - Install TypeScript dependencies automatically in test setup The TypeScriptServer factory provides: - startSse(port): Start SSE transport server - startStdio(): Start STDIO transport server - stop(): Graceful server shutdown - installDependencies(): npm install automation <!-- Provide a brief summary of your changes --> ## Motivation and Context To resurrect typescript tests ## How Has This Been Tested? Locally, CI ## Breaking Changes <!-- Will users need to update their code or configurations? --> ## Types of changes - [x] Bug fix (non-breaking change which fixes an issue) - [x] Test fix ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [x] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [x] My code follows the repository's style guidelines - [x] New and existing tests pass locally - [ ] I have added appropriate error handling - [ ] I have added or updated documentation as needed ## Additional context #475
Contributor
|
@Fuud, I guess the PR is no longer relevant. Do you think we should keep it open? |
Contributor
Author
|
Let's close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
kotlin-sdk-testusestypescript-sdkfrom git.Structure of
typescript-sdkwas changed, it was splitted on modules, now it requires pnpm.How Has This Been Tested?
regular gradle build now works as expected
Breaking Changes
no, only tests was changed
Types of changes
Checklist
Additional context