Open
Conversation
pedro18x
approved these changes
Apr 23, 2026
Fishbowler
approved these changes
Apr 23, 2026
Contributor
Fishbowler
left a comment
Fishbowler
left a comment
There was a problem hiding this comment.
Looks good. I've clarified a few for readability.
Comment on lines
+25
to
+26
| - Make `Maestro` methods natively `suspend` so coroutine cancellation propagates through to device IO, enabling `withTimeout { orchestra.runFlow(...) }` to actually cancel stuck gRPC calls | ||
| - Orchestra properly respects coroutine cancellation in command, scroll, repeat, and subflow loops; previously, cancellation could scroll or retry forever |
Contributor
There was a problem hiding this comment.
Suggested change
| - Make `Maestro` methods natively `suspend` so coroutine cancellation propagates through to device IO, enabling `withTimeout { orchestra.runFlow(...) }` to actually cancel stuck gRPC calls | |
| - Orchestra properly respects coroutine cancellation in command, scroll, repeat, and subflow loops; previously, cancellation could scroll or retry forever | |
| - Fixes to cancelling flow execution when inside a long-running command |
Comment on lines
+23
to
+24
| - Replace Android TCP port forwarding with a direct ADB socket for gRPC - around 41% faster on a simple `assertVisible` flow, and removes the flaky forwarding thread that fought with | ||
| Studio/CLI/MCP running side-by-side |
Contributor
There was a problem hiding this comment.
Suggested change
| - Replace Android TCP port forwarding with a direct ADB socket for gRPC - around 41% faster on a simple `assertVisible` flow, and removes the flaky forwarding thread that fought with | |
| Studio/CLI/MCP running side-by-side | |
| - Replace Android TCP port forwarding with a direct ADB socket for gRPC - around 41% faster on a simple `assertVisible` flow, and removes the flaky forwarding thread that fought with Studio/CLI/MCP running side-by-side |
Contributor
There was a problem hiding this comment.
Does this imply that running CLI alongside Studio is now fixed?
| - Normalize resolved workspace paths so `..` segments collapse on zip filesystems | ||
| - Guard `WorkingDirectory.resolve(String)` against absolute paths, fixing doubled paths that broke MCP auto-run | ||
| - Show progress for the whole multipart cloud upload (workspace zip + app binary + mapping), not just the app binary | ||
| - Add a soft CLI warning when the workspace zip produced by `maestro cloud` exceeds 20 MB, since oversized uploads slow queue and run times across the fleet |
Contributor
There was a problem hiding this comment.
Suggested change
| - Add a soft CLI warning when the workspace zip produced by `maestro cloud` exceeds 20 MB, since oversized uploads slow queue and run times across the fleet | |
| - Add a CLI warning when the workspace zip produced for `maestro cloud` exceeds 20 MB, since oversized uploads slow queue and run times across the fleet |
| - Fix `--android-api-level` and `--ios-version` being silently ignored on cloud uploads | ||
| - Normalize resolved workspace paths so `..` segments collapse on zip filesystems | ||
| - Guard `WorkingDirectory.resolve(String)` against absolute paths, fixing doubled paths that broke MCP auto-run | ||
| - Show progress for the whole multipart cloud upload (workspace zip + app binary + mapping), not just the app binary |
Contributor
There was a problem hiding this comment.
Suggested change
| - Show progress for the whole multipart cloud upload (workspace zip + app binary + mapping), not just the app binary | |
| - Show upload progress in `maestro cloud` CLI output for the whole upload (workspace zip + app binary + mapping), not just the app binary |
| - Fix workspace ZIP path traversal for single-flow cloud uploads - zip entries are now rooted at the deepest common ancestor, eliminating broken `../` segments | ||
| - Fix `--android-api-level` and `--ios-version` being silently ignored on cloud uploads | ||
| - Normalize resolved workspace paths so `..` segments collapse on zip filesystems | ||
| - Guard `WorkingDirectory.resolve(String)` against absolute paths, fixing doubled paths that broke MCP auto-run |
Contributor
There was a problem hiding this comment.
Suggested change
| - Guard `WorkingDirectory.resolve(String)` against absolute paths, fixing doubled paths that broke MCP auto-run | |
| - Fix a file dependency resolution problem when users provided absolute paths |
| - Remove CLI-side `--app-binary-id` validation - server-side already handles it | ||
| - Remove the unmaintained `recipes/` folder; examples now live at https://docs.maestro.dev/examples | ||
| - Fix log folder name generation where outputs were being split across two similarly-timestamped directories, and extend `XDG_STATE_HOME` support to log outputs | ||
| - Fix `ToastAccessibilityListener` crashing with `NoSuchElementException` on notification events with an empty text list (Android 11+) |
Contributor
There was a problem hiding this comment.
Suggested change
| - Fix `ToastAccessibilityListener` crashing with `NoSuchElementException` on notification events with an empty text list (Android 11+) | |
| - Fix `ToastAccessibilityListener` crashing Maestro when toast nodes have no text (Android) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.