fix: support iOS 26 photo picker in view hierarchy snapshots#3183
Open
StasKeiss wants to merge 3 commits intomobile-dev-inc:mainfrom
Open
fix: support iOS 26 photo picker in view hierarchy snapshots#3183StasKeiss wants to merge 3 commits intomobile-dev-inc:mainfrom
StasKeiss wants to merge 3 commits intomobile-dev-inc:mainfrom
Conversation
On iOS 26, PHPickerViewController runs as an out-of-process extension
(com.apple.mobileslideshow.photospicker) whose UI is invisible in the
host app's accessibility tree. This adds the picker's hierarchy to the
snapshot response using the same pattern as SafariViewService, enabling
Maestro to see and interact with photo picker elements.
Contributor
|
Nice ❤️ How would we go about adding an e2e test for this? |
Author
|
@Fishbowler You mean add a test to the Flutter app? I don't really know Flutter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add support for iOS 26's photo picker (
PHPickerViewController) in Maestro's view hierarchy snapshots. A newgetPhotoPickerHierarchy()method inViewHierarchyHandler.swiftfetches the pickerextension's accessibility tree and merges it into the hierarchy response — following the same pattern used for
SFSafariViewControllerviaSafariViewService.Impact
Maestro flows that interact with the native iOS photo picker (selecting images from the gallery) will now work on iOS 26+. Previously, the picker's UI elements were completely invisible to Maestro, causing flows
to fail when trying to tap on photos. No impact on iOS versions below 26 (the method early-returns via an OS version guard).
Root cause
In iOS 26, Apple changed
PHPickerViewControllerto run as an out-of-process extension (com.apple.mobileslideshow.photospicker) rather than rendering within the host app's process. As a result, the picker's UIelements no longer appear in the host app's accessibility tree — Maestro sees an empty opaque container instead of buttons, images, and labels. This is the same architectural change Apple made to
SFSafariViewController(which now runs incom.apple.SafariViewService), and the existing Safari fix in this codebase was the model for this fix.Fix
Query the photo picker extension's process directly via
XCUIApplication(bundleIdentifier: "com.apple.mobileslideshow.photospicker"), check if it's running, snapshot its accessibility hierarchy, and include italongside the app hierarchy in the response — identical to how
getSafariWebViewHierarchy()handles the Safari case.The docs need to be updated accordingly - https://docs.maestro.dev/examples/recipes/choose-images-from-the-gallery