This repository was archived by the owner on Aug 28, 2019. It is now read-only.
Add option to disable social share links site-wide#175
Open
boomshadow wants to merge 3 commits intommistakes:masterfrom
Open
Add option to disable social share links site-wide#175boomshadow wants to merge 3 commits intommistakes:masterfrom
boomshadow wants to merge 3 commits intommistakes:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I personally don't care about social sharing links on my site. I think others might also like the ability to turn this off for the whole site from the config.
I also was able to remove the check for 'if not equal false', which is not considered best coding practices. This changes make the logic in the layouts a little more readable, and gives the extra 'site-wide' disable option.