Skip to content

Change venv name to mlcflow#227

Open
anandhu-eng wants to merge 3 commits into
devfrom
anandhu-eng-patch-1
Open

Change venv name to mlcflow#227
anandhu-eng wants to merge 3 commits into
devfrom
anandhu-eng-patch-1

Conversation

@anandhu-eng
Copy link
Copy Markdown
Contributor

✅ PR Checklist

  • Target branch is dev

📌 Note: PRs must be raised against dev. Do not commit directly to main.

✅ Testing & CI

  • Have tested the changes in my local environment, else have properly conveyed in the PR description
  • The change includes a GitHub Action to test the script(if it is possible to be added).
  • No existing GitHub Actions are failing because of this change.

📚 Documentation

  • README or help docs are updated for new features or changes.
  • CLI help messages are meaningful and complete.

📁 File Hygiene & Output Handling

  • No unintended files (e.g., logs, cache, temp files, pycache, output folders) are committed.

🛡️ Safety & Security

  • No secrets or credentials are committed.
  • Paths, shell commands, and environment handling are safe and portable.

🙌 Contribution Hygiene

  • PR title and description are concise and clearly state the purpose of the change.
  • Related issues (if any) are properly referenced using Fixes # or Closes #.
  • All reviewer feedback has been addressed.

@anandhu-eng anandhu-eng requested a review from a team as a code owner April 16, 2026 14:14
@github-actions
Copy link
Copy Markdown

🤖 AI PR Review Summary\n\nThis PR updates the documentation to reflect a change in the default virtual environment directory from ~/.mlcflow_venv to ~/.mlcflow. The changes are purely documentation updates with no code modifications, reducing risk. However, consistency across all references is critical to avoid user confusion. There are no design issues as this is a straightforward rename in docs.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@github-actions
Copy link
Copy Markdown

🤖 AI PR Review Summary\n\nThis PR updates the default virtual environment directory from ~/.mlcflow_venv to ~/.mlcflow across installation scripts and documentation. The change is consistent and low risk but requires users to update their environment activation commands accordingly. There are no design issues, but careful verification is needed to ensure no references to the old path remain.

@github-actions
Copy link
Copy Markdown

🤖 AI PR Review Summary\n\nThis PR updates the default virtual environment directory from ~/.mlcflow_venv to ~/.mlcflow across GitHub workflows, installation scripts, and documentation. The change is mostly cosmetic and organizational, reducing the verbosity of the venv directory name. Risks are minimal but include potential confusion or breakage if users or scripts rely on the old path. The change is consistently applied, but no migration or backward compatibility notes are included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant