[FIX] Rename T.alloc_buffer to T.sblock_alloc_buffer#3457
[FIX] Rename T.alloc_buffer to T.sblock_alloc_buffer#3457babusid merged 1 commit intomlc-ai:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a necessary API update across the codebase to align with a recent refactoring in the TVM framework. The change specifically targets buffer allocation calls, ensuring compatibility and resolving silent compilation failures, thereby maintaining the stability and functionality of the system. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
5f3f769 to
21d8820
Compare
There was a problem hiding this comment.
Code Review
This pull request correctly updates the codebase by renaming all instances of T.alloc_buffer to T.sblock_alloc_buffer. This change is necessary to adapt to a recent API refactoring in the upstream TVM project, fixing potential compilation failures. The changes are applied consistently across all relevant files, and I found no issues with the implementation.
21d8820 to
87ab0c7
Compare
This PR fixes compilation silent failures due to a recent refactor in mainline TVM apache/tvm#18865.
87ab0c7 to
d28f8a3
Compare
This PR fixes compilation silent failures due to a recent refactor in mainline TVM apache/tvm#18865.