Enable input of non ascii characters for TextBox#117
Open
oikumene wants to merge 3 commits intomitsuba-renderer:masterfrom
Open
Enable input of non ascii characters for TextBox#117oikumene wants to merge 3 commits intomitsuba-renderer:masterfrom
oikumene wants to merge 3 commits intomitsuba-renderer:masterfrom
Conversation
oikumene
changed the title
wjakob
force-pushed
the
master
branch
11 times, most recently
from
e9c6fc9 to
0f47fe0
Compare
wjakob
force-pushed
the
master
branch
9 times, most recently
from
654b8a5 to
1cbff2e
Compare
wjakob
force-pushed
the
master
branch
6 times, most recently
from
21626d0 to
d368a4f
Compare
wjakob
force-pushed
the
master
branch
19 times, most recently
from
c75898b to
1bbd038
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable input of non-ascii unicode characters for TextBox.
Enable input from Input Method (like mozc for Japanese) for TextBox.
I could not find a way to distinguish "Enter key solely pressed" and "Enter key when committing conversion in the Input Method". To enable input from an Input Method, I changed that text in TextBox is not committed at ENTER. Now text is committed only when mouse left button is pressed on other the the TextBox.
I hope this specification change is accepted, or someone let me know the way to distinguish the two ENTER.