Draft
Conversation
rhysyngsun
force-pushed
the
nl/add_prefetched_serializers
branch
from
06096f2 to
42652f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Part of https://github.com/mitodl/hq/issues/9559
Description (What does it do?)
This adds a
ModelSerializerbase class that allows serializers to define how data should be fetched for them. An accompanying view is also present that derives the queryset for the view from this. In practice this means that we only need to define our prefetches and annotations once per serializer and the prefetches automatically get picked up. This also gives us free support for varying the queryset based on the serializer returned byget_serializer_class.In mit-learn we've accomplished a similar mechanism with
for_serializationbut I ran into limits with this in my work for this issue.How can this be tested?
Additional Context