fix(deps): update dependency rmwc to v14#1313
Conversation
renovate
bot
force-pushed
the
renovate/rmwc-14.x
branch
3 times, most recently
from
e8fa94c to
ff11c1c
Compare
|
It requires material-components-web >=5 |
renovate
bot
force-pushed
the
renovate/rmwc-14.x
branch
9 times, most recently
from
ef88591 to
72e9fd6
Compare
renovate
bot
force-pushed
the
renovate/rmwc-14.x
branch
2 times, most recently
from
481c1fa to
33dea52
Compare
renovate
bot
force-pushed
the
renovate/rmwc-14.x
branch
3 times, most recently
from
b12b201 to
f0c0fef
Compare
renovate
bot
force-pushed
the
renovate/rmwc-14.x
branch
10 times, most recently
from
cc4613a to
70c41a1
Compare
renovate
bot
force-pushed
the
renovate/rmwc-14.x
branch
from
70c41a1 to
9ddfb09
Compare
renovate
bot
force-pushed
the
renovate/rmwc-14.x
branch
11 times, most recently
from
db46b62 to
167208f
Compare
renovate
bot
force-pushed
the
renovate/rmwc-14.x
branch
7 times, most recently
from
cdb1a9c to
cc6d007
Compare
renovate
bot
force-pushed
the
renovate/rmwc-14.x
branch
from
cc6d007 to
889cfcd
Compare
renovate
bot
force-pushed
the
renovate/rmwc-14.x
branch
6 times, most recently
from
c846eaa to
a0bb5bb
Compare
renovate
bot
force-pushed
the
renovate/rmwc-14.x
branch
from
a0bb5bb to
c4c9007
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| "redux-logger": "^3.0.6", | ||
| "redux-thunk": "^3.0.0", | ||
| "rmwc": "^1.4.1", | ||
| "rmwc": "^14.0.0", | ||
| "sanitize-filename": "^1.6.1", |
There was a problem hiding this comment.
Bug: Direct imports from @material/* packages use outdated paths from v0.x, which are incompatible with the upgraded v14 dependencies, causing a runtime crash.
Severity: CRITICAL
Suggested Fix
Update the import statements in Dialog.js, Drawer.js, and Menu.js to use the new API and package structure of Material Components Web v14.0.0. Replace the outdated imports from /dist/mdc.* paths with the correct v14-compatible exports.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L90-L93
Potential issue: The pull request upgrades `rmwc` to v14.3.5 and its underlying
`@material/*` dependencies to v14.0.0. However, several component files, including
`Dialog.js`, `Drawer.js`, and `Menu.js`, continue to use direct import paths from the
old Material Components Web v0.x distribution structure (e.g., `import { MDCDialog }
from "@material/dialog/dist/mdc.dialog"`). These paths do not exist in the v14.0.0
release. This incompatibility will cause a runtime error, such as `Cannot find module`,
when the application attempts to render these components, leading to a crash.
Did we get this right? 👍 / 👎 to inform future reviews.
| "redux-thunk": "^3.0.0", | ||
| "rmwc": "^1.4.1", | ||
| "rmwc": "^14.0.0", | ||
| "sanitize-filename": "^1.6.1", |
There was a problem hiding this comment.
Bug: The rmwc library upgrade to v14 breaks existing component imports like import { LinearProgress } from "rmwc/LinearProgress", which will cause a module not found error at load time.
Severity: CRITICAL
Suggested Fix
Update all rmwc imports to conform to the new v14 package structure. For example, change import { LinearProgress } from "rmwc/LinearProgress" to use the new scoped package import, such as import { LinearProgress } from "@rmwc/linear-progress".
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L93
Potential issue: The pull request upgrades the `rmwc` library from version 1.x to 14.x,
which is a major breaking change. The existing code imports components using the old
path structure, for example, `import { LinearProgress } from "rmwc/LinearProgress"`. In
`rmwc` v14, the package structure was changed to use scoped packages, making this import
path invalid. This will cause a 'module not found' error when the application attempts
to load any component using this old import syntax, such as `LoadingIndicator.js`,
preventing it from rendering.
| material-components-web@^0.33.0, material-components-web@^14.0.0: | ||
| version "0.33.0" |
There was a problem hiding this comment.
Bug: The resolutions in package.json force material-components-web to ^0.33.0, but the upgraded rmwc package requires ^14.0.0, creating a conflict that will cause runtime errors.
Severity: CRITICAL
Suggested Fix
Remove the **/material-components-web resolution from package.json. This will allow the package manager to install version ^14.0.0 of material-components-web, which is compatible with the newly upgraded rmwc package.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: yarn.lock#L7188-L7189
Potential issue: The `package.json` file contains a `resolutions` field that pins
`material-components-web` to version `^0.33.0`. This pull request upgrades `rmwc` to
version `14.3.5`, which has a dependency on `material-components-web@^14.0.0`. The
explicit resolution forces yarn to install version `0.33.0`, which is incompatible with
the version `^14.0.0` required by `rmwc`. This mismatch will lead to runtime crashes
whenever a Material Design component from `rmwc` is rendered, as the expected APIs from
`material-components-web` v14 will not be present in the installed v0.33.0.
1 participant
This PR contains the following updates:
^1.4.1→^14.0.0Release Notes
rmwc/rmwc (rmwc)
v14.3.5Compare Source
🩹 Fixes
❤️ Thank You
v14.3.4Compare Source
🩹 Fixes
❤️ Thank You
v14.3.3Compare Source
🩹 Fixes
❤️ Thank You
v14.3.2Compare Source
🩹 Fixes
❤️ Thank You
v14.3.1Compare Source
🩹 Fixes
❤️ Thank You
v14.3.0Compare Source
🚀 Features
❤️ Thank You
v14.2.9Compare Source
This was a version bump only, there were no code changes.
v14.2.8Compare Source
This was a version bump only, there were no code changes.
v14.2.7Compare Source
v14.2.6Compare Source
v14.2.5Compare Source
v14.2.2Compare Source
v14.2.1Compare Source
v14.2.0Compare Source
v14.1.5Compare Source
v14.1.4Compare Source
v14.1.3Compare Source
v14.1.2Compare Source
v14.1.1Compare Source
v14.1.0Compare Source
v14.0.12Compare Source
v14.0.11Compare Source
v14.0.10Compare Source
v14.0.9Compare Source
v14.0.8Compare Source
v14.0.7Compare Source
v14.0.6Compare Source
v14.0.5Compare Source
v14.0.4Compare Source
v14.0.3Compare Source
v14.0.2Compare Source
v14.0.1Compare Source
v14.0.0Compare Source
v8.0.8Compare Source
v8.0.7Compare Source
Build System / Dependencies
bc4e918)ac855d9)23653f4)e2cded7)04db589)ffe7ad5)b6fc93b)7f3831e)Chores
c97a9b0)ce620ed)fc32a16)9c933e9)Continuous Integration
fe49907)0b280ac)0b4ab07)Bug Fixes
a4076f4)fe69482)1f490ca)530d791)Other Changes
2a1658f)v8.0.6Compare Source
Build System / Dependencies
04db589)ffe7ad5)b6fc93b)Continuous Integration
fe49907)0b280ac)0b4ab07)Bug Fixes
a4076f4)fe69482)1f490ca)530d791)Other Changes
2a1658f)v8.0.5Compare Source
Continuous Integration
b970c86)0b4ab07)Bug Fixes
1f490ca)530d791)Other Changes
2a1658f)v8.0.4Compare Source
Bug Fixes
14.0.2-alpha.0 (2023-09-12)
14.0.1-alpha.0 (2023-09-05)
14.0.0-alpha.0 (2023-08-22)
Other Changes
e6d1296)13.0.0 (2023-07-10)
Build System / Dependencies
e8728b2)d2393b7)b483069)ead6be6)56a7523)5071782)0c21691)c21b815)7e4560c)89f42b8)86b7986)46da54b)70aafb2)c3d4f73)e37216b)Chores
ed28f52)c4d0a89)0f7112a)0d0f103)5522d05)1ee9da2)4dd61ae)50e4944)5d50c52)0306f43)Continuous Integration
5dc73a2)New Features
b793b28)867c1a2)7322aac)721eec5)Bug Fixes
b234307)949078e)63e2338)f0dca9d)b260fd3)c193669)e82416a)af11315)6fbeff7)3e0fae8)7a1a5d7)aa9fefd)582af4e)cd4fcc6)2b48ad6)d3ab60e)8f930f0)4e4353e)08e823d)ae1cf63)1d5576c)3ef0ef5)ac32923)Other Changes
c3fc028)3446c95)5bde24e)afcf60c)debaefd)d07808f)a3db450)8e61edf)b69c05e)8.0.7 (2023-03-20)
Build System / Dependencies
bc4e918)ac855d9)23653f4)e2cded7)04db589)ffe7ad5)b6fc93b)7f3831e)Chores
c97a9b0)ce620ed)fc32a16)9c933e9)Continuous Integration
fe49907)0b280ac)0b4ab07)Bug Fixes
a4076f4)fe69482)1f490ca)530d791)Other Changes
2a1658f)8.0.6 (2023-03-19)
Build System / Dependencies
04db589)ffe7ad5)b6fc93b)Continuous Integration
fe49907)0b280ac)0b4ab07)Bug Fixes
a4076f4)fe69482)1f490ca)530d791)Other Changes
2a1658f)8.0.5 (2023-02-09)
Continuous Integration
b970c86)0b4ab07)Bug Fixes
1f490ca)530d791)Other Changes
2a1658f)8.0.4 (2023-01-05)
Continuous Integration
70540de)Bug Fixes
530d791)Other Changes
2a1658f)8.0.3 (2022-10-12)
Chores
12b4c44)Bug Fixes
d5936d7)8.0.2 (2022-10-12)
Chores
c47f003)Bug Fixes
f9a609d)8.0.1 (2022-08-05)
Breaking Changes
32c4b87)4f3b4e7)Build System / Dependencies
f3b32fe)8dfd5c8)1df5175)d17712e)Chores
9ca79cd)50507f2)Bug Fixes
ed4155f)84eaf25)119478a)4a7e45c)beb9d43)b37c182)ffacae5)cda0c06)e1e912f)3aa9d2f)59e0400)bd9571f)238b10d)496cd54)24008b5)961f80f)82fc5ef)c76b64a)b428490)7c4e4d7)c9e78d1)442db8d)0701914)e3f3433)d2c1970)6a7dd2d)4044f7d)3574106)10925e0)d794eb5)e11b3b7)142f321)ac884a3)Other Changes
47398ed)e7bdd0f)1b6dc7a)aabddfd)fc6dbdf)f65b977)402fcef)511db98)a4d2002)c76d350)2a165ed)e4cf416)bea038b)210bca6)d2f7a13)7e64fcb)f6d751a)12ca023)70c311a)eeb8cc8)89c8217)6c4c992)a59c499)6daf315)ccd7493)Refactors
fa886d7)Reverts
9fde841)Tests
7e3b4b0)af32c67)06ca13b)8.0.0 (2022-06-01)
Breaking Changes
32c4b87)4f3b4e7)Build System / Dependencies
f3b32fe)8dfd5c8)1df5175)d17712e)Chores
50507f2)Bug Fixes
119478a)4a7e45c)beb9d43)b37c182)ffacae5)cda0c06)e1e912f)3aa9d2f)59e0400)bd9571f)238b10d)496cd54)24008b5)961f80f)82fc5ef)c76b64a)b428490)7c4e4d7)c9e78d1)442db8d)0701914)e3f3433)d2c1970)6a7dd2d)4044f7d)3574106)10925e0)d794eb5)e11b3b7)142f321)ac884a3)Other Changes
47398ed)e7bdd0f)1b6dc7a)aabddfd)fc6dbdf)f65b977)402fcef)511db98)a4d2002)c76d350)2a165ed)e4cf416)bea038b)210bca6)d2f7a13)7e64fcb)f6d751a)12ca023)70c311a)eeb8cc8)89c8217)6c4c992)a59c499)6daf315)ccd7493)Refactors
fa886d7)Reverts
9fde841)Tests
7e3b4b0)af32c67)06ca13b)7.0.3 (2022-03-06)
Other Changes
a4d2002)c76d350)bea038b)210bca6)7.0.2 (2022-03-06)
Other Changes
bea038b)210bca6)7.0.1 (2022-03-06)
Other Changes
210bca6)7.0.0 (2022-02-17)
Chores
7e22a0e)9350f1e)25aa225)Bug Fixes
5e02217)3ee72fc)bd59dba)261a731)d963fc4)Other Changes
dd22bdd)6.1.4 (2020-09-11)
Build System / Dependencies
0e5d097)New Features
ab155a9)Bug Fixes
616ee47)b34c0b4)cd556bc)b9fdc94)748bdf3)ed0f009)Other Changes
e03ed26)Tests
e882c13)b0600e2)6.1.3 (2020-06-15)
6.1.2 (2020-06-11)
6.1.1 (2020-06-11)
Bug Fixes
4a3e57d)905f9c8)fd6a73b)c4ff766)Other Changes
a54056d)6.1.0 (2020-04-22)
New Features
457a7c7)Bug Fixes
73fc81c)Other Changes
29f2c26)2e7592a)c8b83f5)61946e8)6.0.14 (2020-04-06)
Bug Fixes
cf1ca2d)6.0.13 (2020-04-06)
Bug Fixes
3a40031)87e8ee7)6.0.12 (2020-04-06)
Bug Fixes
4d7a4a1)6.0.11 (2020-04-05)
Bug Fixes
80bb6b0)6.0.10 (2020-04-05)
Chores
bebd953)New Features
a9ef980)Bug Fixes
f4be0eb)2dc5a7b)fb699af)6.0.9 (2020-04-03)
Bug Fixes
37971c7)6.0.8 (2020-04-01)
Bug Fixes
24ae55d)6.0.7 (2020-04-01)
Bug Fixes
8bf2f52)6.0.6 (2020-04-01)
Bug Fixes
313d56d)6.0.5 (2020-03-30)
Bug Fixes
889fd29)6.0.4 (2020-03-30)
Chores
b65507a)Bug Fixes
bb02369)6.0.3 (2020-03-29)
Bug Fixes
TypeError: Cannot read property "name" of undefined(fcf51f3)Other Changes
0a43481)6.0.2 (2020-03-28)
Bug Fixes
9c7f181)6.0.1 (2020-03-28)
Bug Fixes
7000437)6.0.0 (2020-03-28)
Bug Fixes
680b1b5)3f47318)1f17d0d)302ea95)41409aa)991885e)34d3679)d707c3d)1b3ed2d)3d63f57)e19795a)028da5b)cc1592a)5a95a47)9dcd619)onNavprop (dab4cce)79b1706)54ed96a)4463d1a)Configuration
📅 Schedule: Branch creation - "every weekend" in timezone US/Eastern, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.