fix(deps): update dependency eslint-plugin-mocha to v11#1292
Open
renovate[bot] wants to merge 1 commit intomasterfrom
Open
fix(deps): update dependency eslint-plugin-mocha to v11#1292renovate[bot] wants to merge 1 commit intomasterfrom
renovate[bot] wants to merge 1 commit intomasterfrom
Conversation
31af35d to
1c5a38d
Compare
Contributor
|
eslint-plugin-mocha is being used in eslint-config-mitodl which is using v6.x. And we cannot upgrade that as mentioned here |
65c4d5f to
14535fd
Compare
f250ea9 to
23ffdd3
Compare
966a0ac to
581c492
Compare
1d69527 to
655b4bc
Compare
3bc7ff7 to
3f75465
Compare
cd1ede6 to
f77680c
Compare
411ab8a to
39602c4
Compare
7fbdf7e to
4e58751
Compare
| "eslint-plugin-babel": "^5.3.0", | ||
| "eslint-plugin-flow-vars": "^0.5.0", | ||
| "eslint-plugin-mocha": "^6.3.0", | ||
| "eslint-plugin-mocha": "^11.0.0", |
There was a problem hiding this comment.
Bug: Upgrading eslint-plugin-mocha to v11 is incompatible with the project's ESLint v6.8.0 and legacy .eslintrc configuration, which will cause the CI linting step to fail.
Severity: CRITICAL
Suggested Fix
Revert the upgrade of eslint-plugin-mocha. Alternatively, perform a coordinated upgrade of ESLint to v9.x and migrate the configuration from .eslintrc to the eslint.config.js format to support the new plugin version.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L53
Potential issue: The project's `package.json` is being updated to use
`eslint-plugin-mocha` v11.0.0, but the project is still on ESLint v6.8.0 and uses a
legacy `.eslintrc` configuration. The new plugin version requires ESLint v9.0.0+ and the
modern flat configuration format (`eslint.config.js`). Although the CI's `yarn install`
command uses `--ignore-engines` and will not fail on the peer dependency mismatch, the
subsequent `npm run lint` command will fail. ESLint v6.8.0 will be unable to load the
incompatible plugin, causing a runtime error that breaks the CI pipeline and blocks
merges.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^6.3.0→^11.0.0Release Notes
lo1tuma/eslint-plugin-mocha (eslint-plugin-mocha)
v11.2.0Enhancements
Build-Related
v11.1.0Compare Source
Bug Fixes
Enhancements
Documentation
Code Refactoring
v11.0.0Compare Source
Breaking Changes
Features
Enhancements
Dependency Upgrades
Code Refactoring
Build-Related
v10.5.0Compare Source
Enhancements
v10.4.3Compare Source
Bug Fixes
v10.4.2Compare Source
Bug Fixes
v10.4.1Compare Source
Bug Fixes
globalspackage to support node versions < v18v10.4.0Compare Source
Features
v10.3.0Compare Source
Features
consistent-spacing-between-blocksrule (#340)Documentation
v10.2.0Compare Source
Features
Documentation
Dependency Upgrades
Build-Related
v10.1.0Compare Source
Enhancements
v10.0.5Compare Source
Bug Fixes
Code Refactoring
v10.0.4Compare Source
Documentation
Dependency Upgrades
v10.0.3Compare Source
Bug Fixes
v10.0.2Compare Source
Bug Fixes
Code Refactoring
v10.0.1Compare Source
Bug Fixes
mochaprefix to "no-empty-description" rule name in rec config (#310)Build-Related
npm-run-allto run lint/test scripts (#308)v10.0.0Compare Source
Breaking Changes
Features
no-empty-descriptionrule. closes #302 (#304)Enhancements
Documentation
Dependency Upgrades
Code Refactoring
Build-Related
markdownlintand fix linting issues (#306)v9.0.0Compare Source
Breaking Changes
Bug Fixes
Features
Enhancements
Dependency Upgrades
Build-Related
v8.2.0Compare Source
Enhancements
Code Refactoring
v8.1.0Compare Source
Bug Fixes
Enhancements
Documentation
no-exports(#271)Build-Related
v8.0.0Compare Source
Breaking Changes
Features
Enhancements
ignoreSkippedforhandle-done-callbackrule (#260)Documentation
Dependency Upgrades
Code Refactoring
v7.0.1Compare Source
Bug Fixes
v7.0.0Compare Source
Breaking Changes
Enhancements
meta.typeand missingfixable: 'code'(#245)Dependency Upgrades
Configuration
📅 Schedule: Branch creation - "every weekend" in timezone US/Eastern, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.