fix(deps): update material-components-web monorepo#1132
fix(deps): update material-components-web monorepo#1132renovate[bot] wants to merge 1 commit intomasterfrom
Conversation
![renovate-approve[bot]](https://avatars.githubusercontent.com/in/7394?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/material-components-web-monorepo
branch
4 times, most recently
from
6e36fbd to
c30efa6
Compare
renovate
bot
force-pushed
the
renovate/material-components-web-monorepo
branch
2 times, most recently
from
b818c77 to
7037613
Compare
renovate
bot
force-pushed
the
renovate/material-components-web-monorepo
branch
from
7037613 to
40ce749
Compare
renovate
bot
force-pushed
the
renovate/material-components-web-monorepo
branch
2 times, most recently
from
050d1a9 to
cb86c29
Compare
renovate
bot
force-pushed
the
renovate/material-components-web-monorepo
branch
2 times, most recently
from
517a688 to
6084ea3
Compare
renovate
bot
force-pushed
the
renovate/material-components-web-monorepo
branch
6 times, most recently
from
387c044 to
a840f45
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/material-components-web-monorepo
branch
11 times, most recently
from
d5dfac5 to
c4c33e5
Compare
renovate
bot
force-pushed
the
renovate/material-components-web-monorepo
branch
6 times, most recently
from
d43d80f to
d7bd979
Compare
renovate
bot
force-pushed
the
renovate/material-components-web-monorepo
branch
15 times, most recently
from
059e6a1 to
5f1d658
Compare
renovate
bot
force-pushed
the
renovate/material-components-web-monorepo
branch
5 times, most recently
from
faf58bf to
70ed749
Compare
|
Upgrading With all the repositories being archived, may be we should think about moving away from these packages. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| "@material/button": "^0.44.0", | ||
| "@material/checkbox": "^0.44.0", | ||
| "@material/dialog": "^0.44.0", | ||
| "@material/drawer": "^0.44.0", |
There was a problem hiding this comment.
Bug: The code uses the MDCTemporaryDrawer class, which was removed in the updated @material/drawer package, causing a runtime crash when the drawer component is used.
Severity: CRITICAL
Suggested Fix
Refactor the code in static/js/components/material/Drawer.js to use the new unified MDCDrawer component API introduced in @material/drawer version 0.39.0 and later. This involves updating the import statement and the component instantiation logic to align with the new library version.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L25
Potential issue: The application will crash at runtime when the drawer component is
mounted. The pull request updates the `@material/drawer` package from version `^0.33.0`
to `^0.44.0`. The new version no longer includes the `MDCTemporaryDrawer` class, which
has been replaced by a unified `MDCDrawer` component. The existing code in
`static/js/components/material/Drawer.js` still attempts to instantiate
`MDCTemporaryDrawer`, which will result in a `TypeError: MDCTemporaryDrawer is not a
constructor` and break the application's navigation functionality.
Did we get this right? 👍 / 👎 to inform future reviews.
| "@material/drawer": "^0.44.0", | ||
| "@material/layout-grid": "^0.41.0", | ||
| "@material/list": "^0.44.0", | ||
| "@material/menu": "^0.44.0", | ||
| "@material/radio": "^0.44.0", | ||
| "@material/textfield": "^0.44.0", | ||
| "@material/toolbar": "^0.44.0", | ||
| "@material/typography": "^0.44.0", | ||
| "@sentry/browser": "10.22.0", | ||
| "@silvermine/videojs-quality-selector": "^1.3.1", | ||
| "autoprefixer": "^10.0.0", |
There was a problem hiding this comment.
Bug: The code instantiates the MDCToolbar component, which has been deprecated and removed in the updated version of material-components-web, causing a runtime error.
Severity: HIGH
Suggested Fix
Refactor static/js/components/material/Toolbar.js to replace the deprecated MDCToolbar component with the recommended @material/top-app-bar component. This will require updating the component's import, instantiation, and associated DOM structure to match the new API.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L18-L35
Potential issue: The application will crash at runtime when the toolbar component is
initialized. The pull request updates `material-components-web` to version `^0.44.0`, in
which the `MDCToolbar` component has been deprecated and removed. The code in
`static/js/components/material/Toolbar.js` still attempts to instantiate `new
MDCToolbar(...)`, which will fail because the component no longer exists in the library.
The recommended migration path is to use the `@material/top-app-bar` component instead.
Did we get this right? 👍 / 👎 to inform future reviews.
| "@material/button": "^0.44.0", | ||
| "@material/checkbox": "^0.44.0", | ||
| "@material/dialog": "^0.44.0", | ||
| "@material/drawer": "^0.44.0", |
There was a problem hiding this comment.
Bug: The SCSS file layout.scss imports from @material/tabs, but this package is removed in the dependency upgrade, which will cause the webpack build to fail.
Severity: CRITICAL
Suggested Fix
Update the SCSS import in static/scss/layout.scss to use the new Material Design Components sub-packages for tabs. The old @import "~@material/tabs/mdc-tabs"; should be replaced with imports for the new individual components, such as @material/tab-bar, @material/tab, @material/tab-scroller, and @material/tab-indicator.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L25
Potential issue: The dependency upgrade removes the `@material/tabs` package, which was
split into multiple sub-packages (e.g., `@material/tab-bar`, `@material/tab`). However,
the SCSS file at `static/scss/layout.scss` still contains an import for
`~@material/tabs/mdc-tabs`. Since the `@material/tabs` package will no longer exist in
`node_modules` after the update, the webpack build process will fail when the
`sass-loader` is unable to resolve this import path. This is a build-time error that
will be caught by the CI pipeline, preventing the pull request from being merged.
1 participant
This PR contains the following updates:
^0.29.0→^0.41.0^0.33.0→^0.44.0^0.33.0→^0.44.0^0.33.0→^0.44.0^0.33.0→^0.44.0^0.24.0→^0.41.0^0.33.0→^0.44.0^0.33.0→^0.44.0^0.33.0→^0.44.0^0.33.0→^0.44.0^0.33.0→^0.44.0^0.28.0→^0.44.0^0.33.0→^0.44.0Release Notes
material-components/material-components-web (@material/base)
v0.41.0Compare Source
v0.40.1Compare Source
v0.39.0Compare Source
v0.35.0Compare Source
v0.34.0Compare Source
material-components/material-components-web (@material/button)
v0.44.1Compare Source
v0.44.0Compare Source
v0.43.0Compare Source
v0.42.0Compare Source
v0.41.0Compare Source
v0.40.1Compare Source
v0.40.0Compare Source
v0.39.1Compare Source
v0.39.0Compare Source
v0.38.1Compare Source
v0.38.0Compare Source
v0.37.1Compare Source
v0.37.0Compare Source
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.0Compare Source
v0.34.1Compare Source
v0.34.0Compare Source
material-components/material-components-web (@material/checkbox)
v0.44.1Compare Source
v0.44.0Compare Source
v0.43.0Compare Source
v0.42.0Compare Source
v0.41.0Compare Source
v0.40.1Compare Source
v0.40.0Compare Source
v0.39.1Compare Source
v0.39.0Compare Source
v0.38.1Compare Source
v0.38.0Compare Source
v0.37.1Compare Source
v0.37.0Compare Source
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.0Compare Source
v0.34.1Compare Source
v0.34.0Compare Source
material-components/material-components-web (@material/dialog)
v0.44.1Compare Source
v0.44.0Compare Source
v0.43.0Compare Source
v0.42.0Compare Source
v0.41.0Compare Source
v0.40.1Compare Source
v0.40.0Compare Source
v0.39.1Compare Source
v0.39.0Compare Source
v0.38.2Compare Source
v0.38.1Compare Source
v0.38.0Compare Source
v0.37.1Compare Source
v0.37.0Compare Source
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.2Compare Source
v0.35.0Compare Source
v0.34.1Compare Source
v0.34.0Compare Source
material-components/material-components-web (@material/drawer)
v0.44.1Compare Source
v0.44.0Compare Source
v0.43.0Compare Source
v0.42.0Compare Source
v0.41.1Compare Source
v0.41.0Compare Source
v0.40.1Compare Source
v0.40.0Compare Source
v0.39.1Compare Source
v0.39.0Compare Source
v0.38.0Compare Source
v0.37.1Compare Source
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.0Compare Source
v0.34.0Compare Source
material-components/material-components-web (@material/layout-grid)
v0.41.0Compare Source
v0.40.1Compare Source
v0.39.0Compare Source
v0.34.0Compare Source
material-components/material-components-web (@material/list)
v0.44.1Compare Source
v0.44.0Compare Source
v0.43.0Compare Source
v0.42.0Compare Source
v0.41.0Compare Source
v0.40.1Compare Source
v0.40.0Compare Source
v0.39.1Compare Source
v0.39.0Compare Source
v0.38.1Compare Source
v0.38.0Compare Source
v0.37.1Compare Source
v0.37.0Compare Source
v0.36.0Compare Source
v0.35.0Compare Source
v0.34.1Compare Source
v0.34.0Compare Source
material-components/material-components-web (@material/menu)
v0.44.1Compare Source
v0.44.0Compare Source
v0.43.0Compare Source
v0.42.1Compare Source
v0.42.0Compare Source
v0.41.0Compare Source
v0.40.1Compare Source
v0.40.0Compare Source
v0.39.1Compare Source
v0.39.0Compare Source
v0.38.0Compare Source
v0.37.1Compare Source
v0.36.1Compare Source
v0.35.0Compare Source
v0.34.0Compare Source
material-components/material-components-web (@material/radio)
v0.44.1Compare Source
v0.44.0Compare Source
v0.43.0Compare Source
v0.42.0Compare Source
v0.41.0Compare Source
v0.40.1Compare Source
v0.40.0Compare Source
v0.39.1Compare Source
v0.39.0Compare Source
v0.38.1Compare Source
v0.38.0Compare Source
v0.37.1Compare Source
v0.37.0Compare Source
v0.36.0Compare Source
v0.35.0Compare Source
v0.34.1Compare Source
v0.34.0Compare Source
material-components/material-components-web (@material/textfield)
v0.44.1Compare Source
v0.44.0Compare Source
v0.43.1Compare Source
v0.43.0Compare Source
v0.42.1Compare Source
v0.42.0Compare Source
v0.41.0Compare Source
v0.40.1Compare Source
v0.40.0Compare Source
v0.39.1Compare Source
v0.39.0Compare Source
v0.38.1Compare Source
v0.38.0Compare Source
v0.37.1Compare Source
v0.37.0Compare Source
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.2Compare Source
v0.35.1Compare Source
v0.35.0Compare Source
v0.34.1Compare Source
v0.34.0Compare Source
material-components/material-components-web (@material/toolbar)
v0.44.1Compare Source
v0.44.0Compare Source
v0.43.0Compare Source
v0.42.0Compare Source
v0.41.0Compare Source
v0.40.1Compare Source
v0.40.0Compare Source
v0.39.1Compare Source
v0.39.0Compare Source
v0.38.1Compare Source
v0.38.0Compare Source
v0.37.1Compare Source
v0.37.0Compare Source
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.0Compare Source
v0.34.1Compare Source
v0.34.0Compare Source
material-components/material-components-web (@material/typography)
v0.44.1Compare Source
v0.44.0Compare Source
v0.43.0Compare Source
v0.42.0Compare Source
v0.41.0Compare Source
v0.40.1Compare Source
v0.39.0Compare Source
v0.38.0Compare Source
v0.37.1Compare Source
v0.35.0Compare Source
v0.34.0Compare Source
material-components/material-components-web (material-components-web)
v0.44.1Compare Source
v0.44.0Compare Source
v0.43.1Compare Source
v0.43.0Compare Source
v0.42.1Compare Source
v0.42.0Compare Source
v0.41.1Compare Source
v0.41.0Compare Source
v0.40.1Compare Source
v0.40.0Compare Source
v0.39.1Compare Source
v0.39.0Compare Source
v0.38.2Compare Source
v0.38.1Compare Source
v0.38.0Compare Source
v0.37.1Compare Source
v0.37.0Compare Source
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.2Compare Source
v0.35.1Compare Source
v0.35.0Compare Source
v0.34.1Compare Source
v0.34.0Compare Source
Configuration
📅 Schedule: Branch creation - "every weekend" in timezone US/Eastern, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.