Skip to content

chore(deps): update dependency eslint to v10 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update dependency eslint to v10 #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend-demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"@types/react-dom": "^19.0.0",
"@typescript-eslint/eslint-plugin": "^8.13.0",
"@typescript-eslint/typescript-estree": "^8.13.0",
"eslint": "^8",
"eslint": "^10.0.0",
Copy link

@sentry sentry bot Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The upgrade to eslint v10 is not accompanied by an update to @typescript-eslint/eslint-plugin, which remains at an incompatible version, 8.46.2.
Severity: CRITICAL

Suggested Fix

Update the @typescript-eslint/eslint-plugin dependency in package.json to a version compatible with ESLint 10, such as ^8.56.0 or later. Then, run your package manager's install command to update the lock file.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: frontend-demo/package.json#L55

Potential issue: The PR upgrades `eslint` to version 10, but the dependency
`@typescript-eslint/eslint-plugin` remains locked at version `8.46.2` in `yarn.lock`.
According to official documentation, support for ESLint 10 was introduced in
`@typescript-eslint/eslint-plugin` version `8.56.0`. The currently locked version is
incompatible, which will cause the `yarn lint-check` command to fail with runtime
errors. This will break the CI/CD pipeline and local development linting workflows.

Copy link

@sentry sentry bot Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Upgrading ESLint to v10 without migrating from .eslintrc.js to the required eslint.config.js (flat config) will cause the linting process to fail.
Severity: CRITICAL

Suggested Fix

Migrate the existing .eslintrc.js configuration to the new eslint.config.js flat config format as required by ESLint v10. This may involve using the @eslint/compat package to wrap legacy configurations for compatibility. Additionally, verify that all ESLint plugins and shared configurations, like eslint-config-mitodl, support the flat config format or update them accordingly.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: frontend-demo/package.json#L55

Potential issue: The pull request updates the ESLint version to `^10.0.0` in
`package.json`. However, ESLint v10 completely removes support for the legacy
`.eslintrc.js` configuration format, which is still used by this project. The required
migration to the new `eslint.config.js` (flat config) format has not been performed. As
a result, when the `lint-check` script runs in CI, ESLint v10 will fail to find a valid
configuration file, causing the entire linting process to fail immediately. This failure
occurs before any linting rules or plugins are even processed.

Copy link

@sentry sentry bot Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The ESLint v10 upgrade is missing the required migration to the new flat config format (eslint.config.js), which will cause the CI linting step to fail.
Severity: CRITICAL

Suggested Fix

Migrate the existing ESLint configuration from .eslintrc.js to the new flat config format by creating an eslint.config.js file. This involves translating the extends, plugins, rules, and overrides into the new array-based configuration structure required by ESLint v10.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: frontend-demo/package.json#L55

Potential issue: The pull request updates the `eslint` dependency to version 10.0.0.
However, ESLint v10 completely removes support for the legacy `.eslintrc.js`
configuration file format and now requires a flat config file, such as
`eslint.config.js`. Since the project's configuration has not been migrated to this new
format, the `yarn run lint-check` command, which is executed in the CI pipeline, will
fail. The ESLint v10 CLI will error out when it cannot find a valid configuration file,
causing the CI build to fail and blocking merges.

Copy link

@sentry sentry bot Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The upgrade to ESLint v10 is incompatible with the project's legacy .eslintrc.js configuration file, which will cause the linting process to fail.
Severity: CRITICAL

Suggested Fix

Before upgrading to ESLint v10, migrate the project's ESLint configuration from the legacy .eslintrc.js format to the new flat config format by creating and configuring an eslint.config.js file. This will ensure compatibility with the new version of ESLint.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: frontend-demo/package.json#L55

Potential issue: The project's dependencies are being updated to ESLint v10 in
`package.json`. However, the project is configured using a legacy `.eslintrc.js` file.
ESLint v10 has completely removed support for this configuration format and now
exclusively requires a flat config file (e.g., `eslint.config.js`). Consequently, any
attempt to run the linting process, such as `yarn lint`, will fail with an error because
ESLint cannot find a valid configuration file. This will break the linting step in the
development and CI/CD pipeline.

Copy link

@sentry sentry bot Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The upgrade to ESLint v10 is incompatible with the installed version of @typescript-eslint/eslint-plugin (8.46.2), which will cause linting tasks to fail.
Severity: CRITICAL

Suggested Fix

Update the version constraint for @typescript-eslint/eslint-plugin in package.json to at least ^8.56.0 to ensure compatibility with ESLint v10. Additionally, migrate the legacy .eslintrc.js configuration to the new flat config format (eslint.config.js) as required by ESLint v10.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: frontend-demo/package.json#L55

Potential issue: The upgrade to ESLint v10 is incompatible with the current dependency
setup. The version constraint for `@typescript-eslint/eslint-plugin` is `^8.13.0`, which
resolves to version `8.46.2`. However, support for ESLint v10 was only added in version
`8.56.0` of the plugin. This mismatch will cause linting tasks to fail immediately upon
installation of dependencies. Furthermore, ESLint v10 no longer supports the legacy
`.eslintrc.js` configuration format used in the project, which will also contribute to
the failure.

Copy link

@sentry sentry bot Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The upgrade to ESLint v10 is missing the required eslint.config.js flat configuration file, which will cause all linting scripts and the CI build to fail.
Severity: CRITICAL

Suggested Fix

Create a new eslint.config.js file and migrate the existing configuration from .eslintrc.js to the new flat config format required by ESLint v10. Ensure all plugins and extensions are compatible with the new system. The old .eslintrc.js file can then be removed.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: frontend-demo/package.json#L55

Potential issue: The `eslint` dependency was upgraded to version 10, which no longer
supports the `.eslintrc.js` configuration file used by this project. The required
migration to a new `eslint.config.js` (flat config) file was not performed. As a result,
any script that invokes ESLint, such as `yarn lint-check`, will fail because it cannot
find a valid configuration. This will cause the CI pipeline to break, blocking future
code merges.

"eslint-config-mitodl": "^2.1.0",
"eslint-config-next": "15.5.12",
"eslint-config-prettier": "^10.0.0",
Comment on lines +55 to 58
Copy link

@sentry sentry bot Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Upgrading to ESLint 10 causes a runtime crash in the linting process due to an incompatibility with eslint-plugin-import, which breaks development workflows like lint-check.
Severity: HIGH

Suggested Fix

To resolve this incompatibility, either downgrade ESLint to version 9.x, or use the @eslint/compat package to wrap the eslint-plugin-import plugin for compatibility with ESLint 10. Alternatively, wait for a new version of eslint-plugin-import that officially supports ESLint 10.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: frontend-demo/package.json#L55-L58

Potential issue: The upgrade of ESLint to version 10.0.0 introduces a runtime
incompatibility with `eslint-plugin-import` (version 2.32.0). The plugin is not
compatible with the structural changes to context objects in ESLint 10. When linting is
executed, such as by running `yarn lint-check`, the process will crash with a
`TypeError` when `eslint-plugin-import` attempts to access properties that no longer
exist. This failure will block all linting operations for the project, impacting the
development workflow and continuous integration checks.

Expand Down
Loading
Loading