Conversation
Co-authored-by: Yaro <yaro@dream-it.es>
* fix(lsp): remove autopairs workaround * fix(env): add padding for fzf-lua --------- Co-authored-by: Yaro <yaro@dream-it.es>
* feat: remove nvim-treesitter dependency for tree-sitter features --------- Co-authored-by: Yaro <yaro@dream-it.es>
installs, i.e. Nix
Works in environment and variables now.
e.g. client.global.get("some.var.here") returns either null or the value
client.global.set("some.var.here", "my-value") sets correctly nested
value.
request.environment.get("some.nested.name"), will try to get the nested
value or return null if not found.
* chore: format query files with `ts_query_ls` * feat(tree-sitter): highlight fragments
There was a problem hiding this comment.
Pull request overview
This PR bundles multiple enhancements and improvements as part of a weekly update cycle. The main feature mentioned in the description is treesitter support for highlighting fragments.
Changes:
- Enhanced treesitter query files with fragment highlighting and formatting improvements
- Added support for whitespace in variable syntax (e.g.,
{{ VAR }}) - Refactored parser configuration into a dedicated module for better maintainability
- Improved JavaScript scripting API with dot notation support for nested object access
- Added grinch_mode configuration option to disable Christmas greetings
- Enhanced content-type inference for inlined files (JSON and CSV)
- Added nil checks in LSP completion functions
Reviewed changes
Copilot reviewed 21 out of 23 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/functional/parser_spec.lua | Updated test to verify whitespace handling in variable syntax |
| lua/tree-sitter/queries/markdown/injections.scm | Fixed comment directive from ;;extends to ;extends |
| lua/tree-sitter/queries/kulala_http/injections.scm | Normalized indentation in query patterns |
| lua/tree-sitter/queries/kulala_http/highlights.scm | Added fragment highlighting and improved formatting |
| lua/kulala/ui/xmas.lua | Refined Christmas season date range and added grinch_mode support |
| lua/kulala/ui/init.lua | Added explicit scope parameter for window options |
| lua/kulala/parser/string_variables_parser.lua | Enhanced regex to support whitespace in variable syntax |
| lua/kulala/parser/request.lua | Moved headers_display initialization and added inlined_files to removal list |
| lua/kulala/parser/document.lua | Enhanced content-type inference for JSON and CSV inlined files |
| lua/kulala/config/parser.lua | New module to handle treesitter parser configuration |
| lua/kulala/config/init.lua | Refactored to use new parser module |
| lua/kulala/config/defaults.lua | Added grinch_mode configuration option |
| lua/kulala/parser/scripts/engines/javascript/lib/src/lib/Utils.ts | New utility functions for dot notation object access |
| lua/kulala/parser/scripts/engines/javascript/lib/src/lib/PreRequestRequest.ts | Formatting improvements and dot notation support |
| lua/kulala/parser/scripts/engines/javascript/lib/src/lib/PostRequestResponse.ts | Code formatting and improved header key checking |
| lua/kulala/parser/scripts/engines/javascript/lib/src/lib/PostRequest.ts | Formatting improvements and dot notation support |
| lua/kulala/parser/scripts/engines/javascript/lib/package.json | Version bump to 1.1.0 |
| lua/kulala/parser/scripts/engines/javascript/lib/package-lock.json | Updated dependency versions |
| lua/kulala/cmd/lsp.lua | Added nil checks for request properties |
| docs/docs/scripts/request-reference.md | Added examples for dot notation in variable access |
| docs/docs/scripts/client-reference.md | Added examples for dot notation in variable access |
| NEWS.md | Added changelog entries for new enhancements |
| .github/PULL_REQUEST_TEMPLATE.md | New PR template with checklist |
Files not reviewed (1)
- lua/kulala/parser/scripts/engines/javascript/lib/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lua/kulala/parser/scripts/engines/javascript/lib/src/lib/PreRequestRequest.ts
Show resolved
Hide resolved
lua/kulala/parser/scripts/engines/javascript/lib/src/lib/PostRequestResponse.ts
Show resolved
Hide resolved
Collaborator
Author
|
@gorillamoe Marco, would you please have a look at Copilot comments for JS, if you have time? |
14 tasks
…pe Add docs (#818) Co-authored-by: Yaro <yaro@dream-it.es>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.